Change all export * in /tools to named exports#12463
Merged
Merged
Conversation
ghoshkaj
changed the title
/tools to named exportsexport * in /tools to named exports
alexvy86
approved these changes
Oct 14, 2022
ghoshkaj
commented
Oct 14, 2022
| renderTypeParameters, | ||
| } from "./RenderingHelpers"; | ||
| export { | ||
| MemberTableProperties, |
Contributor
Author
There was a problem hiding this comment.
ooo @alexvy86 actually look it's because MemberTableProperties is the first export here, after a bunch of r's from the module prior.
sharptrip
pushed a commit
to sharptrip/FluidFramework
that referenced
this pull request
Oct 17, 2022
This PR converts all `export *` in `/tools` to named exports. Related issue: microsoft#10062 See for the fact that bundle size does not change when the entire repo is converted: microsoft#12321 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts all
export *in/toolsto named exports.Related issue: #10062
See for the fact that bundle size does not change when the entire repo is converted: #12321 (comment). I could not merge that PR because it is too large for one change and would make main-next integration a nightmare.