Change all export * in packages/drivers to named exports#12472
Merged
Conversation
anthony-murphy
approved these changes
Oct 14, 2022
alexvy86
approved these changes
Oct 14, 2022
sharptrip
pushed a commit
to sharptrip/FluidFramework
that referenced
this pull request
Oct 17, 2022
…ft#12472) This PR converts all `export *` in `packages/drivers` to named exports. Related issue: microsoft#10062 See for the fact that bundle size does not change when the entire repo is converted: microsoft#12321 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts all
export *inpackages/driversto named exports.Related issue: #10062
See for the fact that bundle size does not change when the entire repo is converted: #12321 (comment).