Update AgentScheduler to implement IFluidLoadable#12491
Merged
Conversation
github-actions
Bot
added
area: framework
Instead of just the class doing so
alexvy86
approved these changes
Oct 14, 2022
Member
Author
|
If |
markfields
added a commit
that referenced
this pull request
Oct 14, 2022
Reduced port of #12491 to int.2.0 release branch. This adds `IFluidLoadable` member to `AgentScheduler` but doesn't update the interfaces, since it's not needed for the bug fix and that would not be suitable for a patch.
markfields
added a commit
to markfields/FluidFramework
that referenced
this pull request
Oct 14, 2022
…oft#12495) Reduced port of microsoft#12491 to int.2.0 release branch. This adds `IFluidLoadable` member to `AgentScheduler` but doesn't update the interfaces, since it's not needed for the bug fix and that would not be suitable for a patch.
markfields
added a commit
that referenced
this pull request
Oct 14, 2022
Reduced port of #12491 to int.1.4 release branch. This adds `IFluidLoadable` member to `AgentScheduler` but doesn't update the interfaces, since it's not needed for the bug fix and that would not be suitable for a patch.
sharptrip
pushed a commit
to sharptrip/FluidFramework
that referenced
this pull request
Oct 17, 2022
AgentScheduler exposes handle but not via IFluidLoadable which makes it hard to access in general.
ChumpChief
reviewed
Oct 19, 2022
| * Agent scheduler distributes a set of tasks/variables across connected clients. | ||
| */ | ||
| export interface IAgentScheduler extends IProvideAgentScheduler, IEventProvider<IAgentSchedulerEvents> { | ||
| export interface IAgentScheduler extends IProvideAgentScheduler, IEventProvider<IAgentSchedulerEvents>, IFluidLoadable { |
Contributor
There was a problem hiding this comment.
Probably would have been better to leave this off IAgentScheduler and only put it on AgentScheduler -- prior to this change the IAgentScheduler was only about usage of the scheduler and not about the data store "stuff".
With this change, it's possible that components that were only intended to be "users" of the scheduler (i.e. were passed an IAgentScheduler but not an AgentScheduler) can now pin a reference to the handle. Maybe consider moving it.
Member
Author
There was a problem hiding this comment.
Can you open an ADO and assign it to me?
markfields
added a commit
that referenced
this pull request
Nov 12, 2022
Reduced port of #12491 to int.1.4 release branch. This adds `IFluidLoadable` member to `AgentScheduler` but doesn't update the interfaces, since it's not needed for the bug fix and that would not be suitable for a patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScheduler exposes handle but not via IFluidLoadable which makes it hard to access in general.
Fixes AB#2251 (which links to an internal discussion in Loop codebase that exposed this gap)