Tree: Cleanup exports#12638
Merged
Merged
Conversation
github-actions
Bot
added
area: dds
alex-pardes
approved these changes
Oct 24, 2022
| import { | ||
| SequenceEditBuilder, | ||
| Transposed as T, | ||
| // eslint-disable-next-line import/no-internal-modules |
Contributor
There was a problem hiding this comment.
Have you considered adding an eslint configuration for the test directory which disables this rule?
Contributor
Author
There was a problem hiding this comment.
I have. I don't really want to encourage people doing this except for the specific files they are testing, but also suppressing it isn't great either, so I don't feel strongly either way.
sharptrip
pushed a commit
to sharptrip/FluidFramework
that referenced
this pull request
Oct 28, 2022
## Description Reduces unneeded export (mainly sequence-change-family and misc package level exports). Note that FieldKinds namespace is removed from package exports because it has not undergone any filtering of its exports. The way it's exported it isn't trivial to remove items that are only needed internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduces unneeded export (mainly sequence-change-family and misc package level exports).
Note that FieldKinds namespace is removed from package exports because it has not undergone any filtering of its exports. The way it's exported it isn't trivial to remove items that are only needed internally.