ci: Don't set version in bundle-size artifacts pipeline#15110
Merged
tylerbutler merged 4 commits intomicrosoft:mainfrom Apr 14, 2023
Merged
ci: Don't set version in bundle-size artifacts pipeline#15110tylerbutler merged 4 commits intomicrosoft:mainfrom
tylerbutler merged 4 commits intomicrosoft:mainfrom
Conversation
Collaborator
tylerbutler
commented
Apr 14, 2023
Abe27342
approved these changes
Apr 14, 2023
Contributor
|
for near-term posterity--a sample failure motivating this change |
Member
Author
|
Thanks for the review, @Abe27342! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to set versions for the build-bundle-size-artifacts pipeline because the pipeline is special - it runs a client build but doesn't publish anything. Working around this properly in either the pipeline or
flub bumpis challenging and would create a much bigger change. Since this is the only pipeline that sets this variable to true, we use that to determine whether to set versions.I could also add a new parameter, but again, that would be a much bigger change and I don't anticipate the parameter being used anywhere else.