Skip to content

ci: Don't set version in bundle-size artifacts pipeline#15110

Merged
tylerbutler merged 4 commits intomicrosoft:mainfrom
tylerbutler:bundle-size-pipeline
Apr 14, 2023
Merged

ci: Don't set version in bundle-size artifacts pipeline#15110
tylerbutler merged 4 commits intomicrosoft:mainfrom
tylerbutler:bundle-size-pipeline

Conversation

@tylerbutler
Copy link
Copy Markdown
Member

@tylerbutler tylerbutler commented Apr 13, 2023

We don't want to set versions for the build-bundle-size-artifacts pipeline because the pipeline is special - it runs a client build but doesn't publish anything. Working around this properly in either the pipeline or flub bump is challenging and would create a much bigger change. Since this is the only pipeline that sets this variable to true, we use that to determine whether to set versions.

I could also add a new parameter, but again, that would be a much bigger change and I don't anticipate the parameter being used anywhere else.

@github-actions github-actions Bot added area: build Build related issues base: main PRs targeted against main branch labels Apr 13, 2023
@msfluid-bot
Copy link
Copy Markdown
Collaborator

msfluid-bot commented Apr 13, 2023

Baseline CI build failed, cannot generate bundle analysis at this time


Baseline commit: 0a88f5b

Generated by 🚫 dangerJS against a5839e8

Comment thread tools/pipelines/templates/build-npm-package.yml Outdated
@tylerbutler tylerbutler marked this pull request as ready for review April 14, 2023 00:12
@tylerbutler tylerbutler requested a review from a team as a code owner April 14, 2023 00:12
@Abe27342
Copy link
Copy Markdown
Contributor

for near-term posterity--a sample failure motivating this change

@tylerbutler
Copy link
Copy Markdown
Member Author

Thanks for the review, @Abe27342!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build related issues base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants