Prevent SharedTree trunk commits from being evicted if they are referenced by branches#15177
Merged
Conversation
Collaborator
⯅ @fluid-example/bundle-size-tests: +32 Bytes
Baseline commit: 1f13911 |
taylorsw04
reviewed
Apr 19, 2023
taylorsw04
reviewed
Apr 20, 2023
taylorsw04
reviewed
Apr 20, 2023
taylorsw04
reviewed
Apr 20, 2023
Contributor
Author
|
/azp run Build - client packages |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run repo-policy-check |
|
Azure Pipelines successfully started running 1 pipeline(s). |
taylorsw04
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the EditManager's trunk eviction code to retain all commits on the trunk that are currently the base for any outstanding branch/fork. It attempts to do so while preserving separation-of-concerns by adding additional events to the Branch class, but not putting any trunk-specific code into the Branch class (e.g. sequence numbers). It also: