Implement SharedTree root local branch as a SharedTreeBranch#15434
Merged
Conversation
noencke
commented
May 3, 2023
noencke
commented
May 3, 2023
noencke
commented
May 3, 2023
noencke
commented
May 3, 2023
jenn-le
approved these changes
May 4, 2023
jenn-le
reviewed
May 4, 2023
Collaborator
⯆ @fluid-example/bundle-size-tests: -2.11 KB
Baseline commit: f369997 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The root local branch is currently managed by the EditManager. This PR replaces it with an actual
SharedTreeBranchinstance, and updates the relevant places to use operations on the branch instance rather than having EditManager and SharedTreeCore re-implement them.There are many more refactors that "fall out" of this initial refactor. I am not attempting to do all of them here. In fact, just the opposite - I am attempting to refrain from doing much more than the minimal amount of changes that are required here as a first pass. Even so, this PR has quite a few changes. I will follow this up with more refactors in the future to continue to simplify our module boundaries and reduce code.