Skip to content

Implement SharedTree root local branch as a SharedTreeBranch#15434

Merged
noencke merged 18 commits into
microsoft:mainfrom
noencke:the-branch
May 6, 2023
Merged

Implement SharedTree root local branch as a SharedTreeBranch#15434
noencke merged 18 commits into
microsoft:mainfrom
noencke:the-branch

Conversation

@noencke
Copy link
Copy Markdown
Contributor

@noencke noencke commented May 3, 2023

Description

The root local branch is currently managed by the EditManager. This PR replaces it with an actual SharedTreeBranch instance, and updates the relevant places to use operations on the branch instance rather than having EditManager and SharedTreeCore re-implement them.

There are many more refactors that "fall out" of this initial refactor. I am not attempting to do all of them here. In fact, just the opposite - I am attempting to refrain from doing much more than the minimal amount of changes that are required here as a first pass. Even so, this PR has quite a few changes. I will follow this up with more refactors in the future to continue to simplify our module boundaries and reduce code.

@noencke noencke requested a review from a team as a code owner May 3, 2023 22:12
@github-actions github-actions Bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch changeset-present and removed changeset-present labels May 3, 2023
Comment thread experimental/dds/tree2/src/shared-tree-core/branch.ts
Comment thread experimental/dds/tree2/src/shared-tree-core/editManager.ts
Comment thread experimental/dds/tree2/src/shared-tree-core/sharedTreeCore.ts Outdated
Comment thread experimental/dds/tree2/src/shared-tree-core/branch.ts Outdated
Comment thread experimental/dds/tree2/src/shared-tree-core/branch.ts Outdated
Comment thread experimental/dds/tree2/src/shared-tree-core/editManager.ts
Comment thread experimental/dds/tree2/src/test/shared-tree-core/editManager.spec.ts Outdated
Comment thread experimental/dds/tree2/src/shared-tree-core/sharedTreeCore.ts Outdated
@noencke noencke requested a review from msfluid-bot as a code owner May 6, 2023 06:33
@msfluid-bot
Copy link
Copy Markdown
Collaborator

@fluid-example/bundle-size-tests: -2.11 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 446.23 KB 446.23 KB +6 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 238.03 KB 238.03 KB +2 Bytes
loader.js 155.15 KB 155.16 KB +6 Bytes
map.js 46.63 KB 46.63 KB +2 Bytes
matrix.js 140.23 KB 140.24 KB +2 Bytes
odspDriver.js 92.33 KB 92.34 KB +6 Bytes
odspPrefetchSnapshot.js 43.57 KB 43.57 KB +4 Bytes
sharedString.js 160.98 KB 160.98 KB +2 Bytes
sharedTree2.js 277.8 KB 275.66 KB -2.14 KB
Total Size 1.72 MB 1.72 MB -2.11 KB

Baseline commit: f369997

Generated by 🚫 dangerJS against 8e0b835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants