Align detached data format with attached pending data#18829
Merged
Conversation
github-actions
Bot
added
base: main
This reverts commit ea80005.
Collaborator
⯅ @fluid-example/bundle-size-tests: +124 Bytes
Baseline commit: 2ab624d |
dannimad
commented
Dec 20, 2023
Contributor
Author
|
I believe there are some tests we could add to serialized.spec.ts but not sure how the files inside are being generated. |
Contributor
Author
|
I'll merge new serialized container format test for serialized.spec.ts in a subsequent PR. |
anthony-murphy
approved these changes
Jan 4, 2024
This was referenced Jan 18, 2024
dannimad
added a commit
that referenced
this pull request
Jan 30, 2024
New try to test new detached format added in testdata repo. See #18829 for more info
alexvy86
pushed a commit
to alexvy86/FluidFramework
that referenced
this pull request
Feb 13, 2024
New try to test new detached format added in testdata repo. See microsoft#18829 for more info
anthony-murphy
added a commit
that referenced
this pull request
Mar 1, 2024
…19893) ## Background This change is the final change for allowing consumers of fluid to call serialize on a container while a container is in an attaching state, which will include a failed attach where the failure didn't cause the container to close. This will aid in the case of offline, network, or server outage by allowing the application to capture the un-attached state of the container, preserve it locally, and later create a new file from it. [AB#5502](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/5502) ## Overview This change enables calling container.serialize while a container is in the attaching state. It is the culmination of many smaller changes that have gone in to enable this change. - #18829 - #19400 - #19246 - #19517 - #19518 - #19590 - #19634 - #19802 --------- Co-authored-by: Tony Murphy <anthonm@microsoft.com> Co-authored-by: Daniel Madrid <105010181+dannimad@users.noreply.github.com> Co-authored-by: jzaffiro <110866475+jzaffiro@users.noreply.github.com> Co-authored-by: Matt Rakow <ChumpChief@users.noreply.github.com>
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 12, 2024
Current serialize API returns a stringified ISummaryTree. In order to consume it, rehydration receives that summary and converts it into an ISnapshotWithBlobContents. This change can be summarized as moving that summary -> snapshot conversion at serialization time. Such a conversion was not exactly equal to current one in order to provide a format similar to IPendingContainerState (ISnapshotTree and ISerializableBlobContents instead of ISnapshotWithBlobContents). Backward compatible.
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 15, 2024
Current serialize API returns a stringified ISummaryTree. In order to consume it, rehydration receives that summary and converts it into an ISnapshotWithBlobContents. This change can be summarized as moving that summary -> snapshot conversion at serialization time. Such a conversion was not exactly equal to current one in order to provide a format similar to IPendingContainerState (ISnapshotTree and ISerializableBlobContents instead of ISnapshotWithBlobContents). Backward compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current serialize API returns a stringified ISummaryTree. In order to consume it, rehydration receives that summary and converts it into an ISnapshotWithBlobContents. This change can be summarized as moving that summary -> snapshot conversion at serialization time. Such a conversion was not exactly equal to current one in order to provide a format similar to IPendingContainerState (ISnapshotTree and ISerializableBlobContents instead of ISnapshotWithBlobContents).
Backward compatible.