GC: Added whether tombstone is enabled to GarbageCollection_end event#18927
Merged
agarwal-navin merged 2 commits intomicrosoft:mainfrom Dec 20, 2023
Merged
GC: Added whether tombstone is enabled to GarbageCollection_end event#18927agarwal-navin merged 2 commits intomicrosoft:mainfrom
agarwal-navin merged 2 commits intomicrosoft:mainfrom
Conversation
github-actions
bot
added
area: runtime
Collaborator
⯅ @fluid-example/bundle-size-tests: +577 Bytes
Baseline commit: 5e965e2 |
markfields
approved these changes
Dec 20, 2023
agarwal-navin
added a commit
to agarwal-navin/FluidFramework
that referenced
this pull request
Jan 4, 2024
…microsoft#18927) Added a `tombstone` property to GarbageCollection_end event to indicate whether throwing on tombstone is enabled for a GC run. This will help to filter out sessions / GC runs where tombstone did not run. The event already had `sweep` property to indicate whether sweep ran. Also, update the `PerformanceEvent` class to use `ITelemetryGenericEventExt` and `ITelemetryPropertiesExt`. This allowed the property `details` in the GarbageCollection_end event to be an object. AB#6397
agarwal-navin
added a commit
that referenced
this pull request
Jan 4, 2024
…enable sweep (#19087) This PR ports the following changes to internal-8.0 branch. internal-8.0 contains changes that will help enable sweep and these are follow ups that did not make it to the branch. - [Initialize GC state as soon as possible and update it on (re)connecti… · 40ad2d4 (github.com)](40ad2d4) - [GC: Fix GC deleted stats not correctly updated for data stores by agarwal-navin · Pull Request #18890 · microsoft/FluidFramework (github.com)](#18890) - [GC: Added whether tombstone is enabled to GarbageCollection_end event by agarwal-navin · Pull Request #18927 · microsoft/FluidFramework (github.com)](https://github.com/microsoft/FluidFramework/pull/18927/files)
agarwal-navin
added a commit
to agarwal-navin/FluidFramework
that referenced
this pull request
Jan 10, 2024
…microsoft#18927) Added a `tombstone` property to GarbageCollection_end event to indicate whether throwing on tombstone is enabled for a GC run. This will help to filter out sessions / GC runs where tombstone did not run. The event already had `sweep` property to indicate whether sweep ran. Also, update the `PerformanceEvent` class to use `ITelemetryGenericEventExt` and `ITelemetryPropertiesExt`. This allowed the property `details` in the GarbageCollection_end event to be an object. AB#6397
agarwal-navin
added a commit
that referenced
this pull request
Jan 23, 2024
…enable sweep (#19204) This PR ports the following changes to internal-7.4 branch. internal-7.4 contains changes that will help enable sweep and these are follow ups that did not make it to the branch. - [Initialize GC state as soon as possible and update it on (re)connecti… · 40ad2d4 (github.com)](40ad2d4) - [GC: Fix GC deleted stats not correctly updated for data stores by agarwal-navin · Pull Request #18890 · microsoft/FluidFramework (github.com)](#18890) - [GC: Added whether tombstone is enabled to GarbageCollection_end event by agarwal-navin · Pull Request #18927 · microsoft/FluidFramework (github.com)](https://github.com/microsoft/FluidFramework/pull/18927/files)
markfields
pushed a commit
to markfields/FluidFramework
that referenced
this pull request
Feb 12, 2024
…enable sweep (microsoft#19204) This PR ports the following changes to internal-7.4 branch. internal-7.4 contains changes that will help enable sweep and these are follow ups that did not make it to the branch. - [Initialize GC state as soon as possible and update it on (re)connecti… · microsoft/FluidFramework@40ad2d4 (github.com)](microsoft@40ad2d4) - [GC: Fix GC deleted stats not correctly updated for data stores by agarwal-navin · Pull Request microsoft#18890 · microsoft/FluidFramework (github.com)](microsoft#18890) - [GC: Added whether tombstone is enabled to GarbageCollection_end event by agarwal-navin · Pull Request microsoft#18927 · microsoft/FluidFramework (github.com)](https://github.com/microsoft/FluidFramework/pull/18927/files)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
tombstoneproperty to GarbageCollection_end event to indicate whether throwing on tombstone is enabled for a GC run. This will help to filter out sessions / GC runs where tombstone did not run. The event already hadsweepproperty to indicate whether sweep ran.Also, update the
PerformanceEventclass to useITelemetryGenericEventExtandITelemetryPropertiesExt. This allowed the propertydetailsin the GarbageCollection_end event to be an object.AB#6397