Solo editing perf track local branch array#19272
Merged
yann-achard-MS merged 8 commits intoJan 18, 2024
Merged
Conversation
yann-achard-MS
commented
Jan 17, 2024
|
|
||
| manager.advanceMinimumSequenceNumber(brand(2)); | ||
| // Advancing the minimum sequence number does not evict any commits because fork1 branches off of the trunk before commit 1. | ||
| // Advancing the minimum sequence number does not evict any commits because fork1 branches off of the trunk at commit 1. |
Contributor
Author
There was a problem hiding this comment.
This change is unrelated. I forgot to commit it in the previous PR.
alex-pardes
reviewed
Jan 18, 2024
alex-pardes
approved these changes
Jan 18, 2024
Collaborator
⯅ @fluid-example/bundle-size-tests: +386 Bytes
Baseline commit: 0302e83 |
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, the "EditManager - Bench No concurrency Many local edits" benchmark reports the following times on a dev workstation:
After this PR:
Changes
The
EditManagernow maintains an array of commits that represents the changes on the local branch that are not yet on the trunk. This saves theEditManagermanager from having to re-crawl the local branch every time a commit from the local branch is sequenced.Breaking Change
No breaking changes