Clean up some internal API names/signatures#19397
Merged
markfields merged 4 commits intomicrosoft:mainfrom Feb 27, 2024
Merged
Conversation
github-actions
bot
added
area: runtime
markfields
commented
Feb 24, 2024
Collaborator
⯅ @fluid-example/bundle-size-tests: +28 Bytes
Baseline commit: 7621bae |
kian-thompson
approved these changes
Feb 27, 2024
anthony-murphy
approved these changes
Feb 27, 2024
markfields
commented
Feb 27, 2024
| * Validate forward compat by using old type in place of current type | ||
| * If breaking change required, add in package.json under typeValidation.broken: | ||
| * "FunctionDeclaration_addTreeToSummary": {"forwardCompat": false} | ||
| * "RemovedFunctionDeclaration_addTreeToSummary": {"forwardCompat": false} |
Member
Author
There was a problem hiding this comment.
@anthony-murphy would it be ok to exclude @internal things from the type tests? I can open a task if so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some internal tweaks I wanted to make while reading through some of this code.