wip: patch tsc-multi with https://github.com/tommy351/tsc-multi/pull/24#19586
Closed
tylerbutler wants to merge 2 commits intomicrosoft:mainfrom
Closed
wip: patch tsc-multi with https://github.com/tommy351/tsc-multi/pull/24#19586tylerbutler wants to merge 2 commits intomicrosoft:mainfrom
tylerbutler wants to merge 2 commits intomicrosoft:mainfrom
Conversation
github-actions
bot
added
dependencies
tylerbutler
commented
Feb 9, 2024
| "extends": [ | ||
| "../../../common/build/build-common/tsconfig.base.json", | ||
| "../../../common/build/build-common/tsconfig.cjs.json", | ||
| "../../../common/build/build-common/tsconfig.bundler.json", |
Member
Author
There was a problem hiding this comment.
This is needed because the auto-gwenerated type test files have bare imports (no extensions). Once that is fixed this should be changed.
tylerbutler
commented
Feb 9, 2024
| "rootDir": "./", | ||
| "outDir": "../../dist/test", | ||
| "module": "ESNext", | ||
| "moduleResolution": "Bundler", |
Member
Author
There was a problem hiding this comment.
Workaround because the generated type tests use bare imports.
tylerbutler
commented
Feb 9, 2024
| { | ||
| "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json", | ||
| "extends": "../../../common/build/build-common/api-extractor-base.json" | ||
| "extends": "../../../common/build/build-common/api-extractor-base.cjs.primary.json" |
Member
Author
There was a problem hiding this comment.
using primary for both esm and cjs because both use the js file extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress. not ready for review