Refactor serializedStateManager fetchSnapshot#20191
Merged
dannimad merged 2 commits intomicrosoft:mainfrom Mar 18, 2024
Merged
Conversation
| } | ||
| return { snapshotTree, version }; | ||
| } else { | ||
| this.snapshot = { |
Contributor
There was a problem hiding this comment.
nit, destructor the object
Suggested change
| this.snapshot = { | |
| const { baseSnapshot, snapshotBlobs} =this.pendingLocalState; | |
| this.snapshot = { |
Contributor
There was a problem hiding this comment.
could also make this.snapshot match pending local state in terms of property names.
Contributor
Author
There was a problem hiding this comment.
Good idea. I'll do that in another PR since it we will need to change those names in several places
Collaborator
anthony-murphy
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some refactoring aroung serializedStateManager.fetchSnapshot including:
I considered writing some unit tests for the new free functions but they don't do anything special but handling undefined cases.