Skip to content

create SnapshotWithBlobs interface #20198

Merged
dannimad merged 14 commits intomicrosoft:mainfrom
dannimad:rename-pending
Mar 19, 2024
Merged

create SnapshotWithBlobs interface #20198
dannimad merged 14 commits intomicrosoft:mainfrom
dannimad:rename-pending

Conversation

@dannimad
Copy link
Copy Markdown
Contributor

@dannimad dannimad commented Mar 19, 2024

-Unify snapshotree and its blobs types into a single interface SnapshotWithBlobs given that they refer to the same summary data and represent just different parts of the same summary.
-Move PendingContainerState interfaces to serializedStateManager
-Fix tests types

There are a couple of changes pending:

  1. Get rid of ISnapshotTreeWithBlobContents which unfortunately it's harder to do than it seems.
  2. Initialize this.snapshot with pendinglocalstate value from the constructor. There is no need to wait until fetchSnapshot.

@github-actions github-actions Bot added area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Mar 19, 2024
Comment thread packages/loader/container-loader/src/serializedStateManager.ts Outdated
Comment thread packages/loader/container-loader/src/serializedStateManager.ts Outdated
@dannimad dannimad changed the title create PendingSnapshot interface create SnapshotWithBlobs interface Mar 19, 2024
@msfluid-bot
Copy link
Copy Markdown
Collaborator

msfluid-bot commented Mar 19, 2024

Baseline CI build failed, cannot generate bundle analysis at this time


Baseline commit: 7d00e81

Generated by 🚫 dangerJS against feb97b4

Comment thread packages/loader/container-loader/src/serializedStateManager.ts Outdated
Comment thread packages/loader/container-loader/src/serializedStateManager.ts Outdated
Comment thread packages/loader/container-loader/src/serializedStateManager.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants