Move obliterate reconnection under separate flag and improve behavior#22080
Merged
anthony-murphy merged 11 commits intoAug 1, 2024
Conversation
Co-authored-by: Abram Sanderson <Abram.sanderson@gmail.com>
…hy/FluidFramework-1 into fix-annotate-rebase
…to fix-annotate-rebase
|
✅ Successfully linked to Azure Boards work item(s): |
|
anthony-murphy
commented
Jul 31, 2024
Collaborator
⯅ @fluid-example/bundle-size-tests: +416 Bytes
Baseline commit: faf7f68 |
Josmithr
reviewed
Jul 31, 2024
…to fix-obliterate-reconnect
…-murphy/FluidFramework-1 into fix-obliterate-reconnect
Co-authored-by: Joshua Smithrud <54606601+Josmithr@users.noreply.github.com>
Abe27342
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The obliterate logic for reconnect is not well defined. This change puts that behavior under a separate flag to ensure reconnects with obliterate are only done intentionally. Secondarily, this change modifies how it works with reconnect when there is a remote obliterate, and a local insert. The change essentially rolls back the insert, rather than having it bypass the obliterate.
related AB#3714