tree: Track which fields change in anchorSet#22367
Merged
CraigMacomber merged 7 commits intoSep 3, 2024
Merged
Conversation
github-actions
Bot
added
area: dds
alexvy86
approved these changes
Sep 3, 2024
CraigMacomber
commented
Sep 3, 2024
| if (event === "childrenChangedAfterBatch") { | ||
| const fieldKeys = this.bufferedEvents | ||
| .filter((e) => e.node === node && e.event === event) | ||
| .map((e) => e.changedField as FieldKey); |
Contributor
Author
There was a problem hiding this comment.
this should use brand for a safer conversion
Contributor
Author
There was a problem hiding this comment.
actually, this is not casting a string to FIeldKey, but casting away undefined. If unchecked, this should use ! rather than as for much better clarity and type safety. I'm going to make it checked via ?? instead.
Josmithr
reviewed
Sep 3, 2024
| bufferedEvents: [] as { | ||
| node: PathNode; | ||
| event: keyof AnchorEvents; | ||
| changedField?: FieldKey; |
Contributor
There was a problem hiding this comment.
What does it mean for this to be undefined? Might be worth adding an explicit type for this so we can more easily document the properties.
Josmithr
reviewed
Sep 3, 2024
Josmithr
approved these changes
Sep 3, 2024
Contributor
Josmithr
left a comment
Josmithr
left a comment
There was a problem hiding this comment.
Left a couple of nitpick suggestions, but otherwise looks good to me.
Josmithr
reviewed
Sep 3, 2024
Josmithr
approved these changes
Sep 3, 2024
Co-authored-by: Joshua Smithrud <54606601+Josmithr@users.noreply.github.com>
Collaborator
⯅ @fluid-example/bundle-size-tests: +1.74 KB
Baseline commit: 6468aea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split off from #22229 for a smaller review.
Reviewer Guidance
The review process is outlined on this wiki page.