Offline: Add recent batch info from DuplicateBatchDetector to summary#22454
Merged
Conversation
Collaborator
⯅ @fluid-example/bundle-size-tests: +2.02 KB
Baseline commit: ac5883c |
Member
Author
|
@kian-thompson can you please take a look? This can't be merged until we're allowed to make breaking changes (it updates the constructor signature of ContainerRuntime). But I'd like to have it ready to go. |
Co-authored-by: Kian Thompson <102998837+kian-thompson@users.noreply.github.com>
msfluid-bot
reviewed
Nov 15, 2024
Collaborator
There was a problem hiding this comment.
Code Coverage Summary
↑ packages.runtime.container-runtime.src.summary:
Line Coverage Change: 0.01% Branch Coverage Change: 0.01%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 95.82% | 95.83% | ↑ 0.01% |
| Line Coverage | 84.84% | 84.85% | ↑ 0.01% |
↑ packages.runtime.container-runtime.src:
Line Coverage Change: 0.01% Branch Coverage Change: 0.02%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 92.90% | 92.92% | ↑ 0.02% |
| Line Coverage | 94.55% | 94.56% | ↑ 0.01% |
↑ packages.runtime.container-runtime.src.opLifecycle:
Line Coverage Change: 0.07% Branch Coverage Change: 0.11%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 95.23% | 95.34% | ↑ 0.11% |
| Line Coverage | 95.39% | 95.46% | ↑ 0.07% |
Baseline commit: 74cb3f7
Baseline build: 307922
Happy Coding!!
Code coverage comparison check passed!!
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
kian-thompson
approved these changes
Nov 15, 2024
markfields
commented
Nov 15, 2024
anthony-murphy
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes AB#13963
We've added a new data structure for tracking "recent" (based on MSN) batchIds which are at risk for seeing a duplicate sequence batchID come in. This data structure is consulted and modified on each incoming batch.
Whenever we summarize, we need to include this state as of the given sequence number, and when we load from a snapshot we need to repopulate it as well.
Why? Because summaries can happen at any time, and a future container loading from that point will need to know the recent batch IDs that may possibly be followed by a sequenced duplicate.