Offline: Only enable DuplicateBatchDetector if Offline Load is enabled#22497
Merged
Conversation
github-actions
Bot
added
area: runtime
Collaborator
⯅ @fluid-example/bundle-size-tests: +345 Bytes
Baseline commit: 819cafa |
anthony-murphy
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to AB#8885
DuplicateBatchDetection maintains a datastructure of all batchIds/sequenceNumbers within the collab window (seqNum > latest MSN), and checks all incoming batchIds against that set. However, until Offline Load is enabled, there will be no duplicate batchIds. So until then, don't bother with this tracking.
Notes about performance
For whenever it is enabled
A simple benchmark shows that the time spent doing DuplicateBatchDetection is not much - around 30ms for data structure size of 1000, which is 99.99%ile collab window in the production data I looked at.
To me this seems acceptable - and more importantly, predictable (in terms of perf characteristics, based on the data structures/algorithms used) - so I don't see benefit in instrumenting the code (which would only slow it down). I tried using
SampledTelemetryHelperin this branch (3bf6045) but decided it wasn't worth it (per this analysis)