tree: Import / Export APIs and demo#22566
Merged
Merged
Conversation
Co-authored-by: Joshua Smithrud <54606601+Josmithr@users.noreply.github.com>
…to independentView
jenn-le
reviewed
Oct 31, 2024
| const args = process.argv.slice(2); | ||
|
|
||
| console.log(`Requires arguments: [<source>] [<destination>] [<edit>]`); | ||
| console.log(`Example arguments: default data/large.concise.json string:10,item:100`); |
Contributor
There was a problem hiding this comment.
the example for edit is a bit confusing to me, maybe expand on its expected format or how this particular example affects the document?
Contributor
Author
There was a problem hiding this comment.
should be better now.
| }, | ||
| ...options, | ||
| }; | ||
| const schemalessConfig = applySchemaToParserOptions(schema, config); |
Contributor
There was a problem hiding this comment.
why is this considered schemaless?
Contributor
Author
There was a problem hiding this comment.
comment added.
| @@ -0,0 +1 @@ | |||
| {"type":"com.fluidframework.example.cli.List","fields":[]} No newline at end of file | |||
Contributor
There was a problem hiding this comment.
is the verbose version supposed to not have any fields?
Contributor
Author
There was a problem hiding this comment.
the default tree does not have any children under this node, so yes. I have however changed the default tree to be a bit bigger so its a better example.
jenn-le
reviewed
Oct 31, 2024
| ): TreeView<TRoot>; | ||
|
|
||
| // TODO: | ||
| // Add stored key versions of Tree.exportVerbose, Tree.exportConcise and Tree.exportCompressed here so tree content can be accessed without a view schema. |
Contributor
There was a problem hiding this comment.
link here for context would be good I think
Contributor
Author
There was a problem hiding this comment.
I have moved these comments to the interface doc comment so they can use the link syntax. They are in privateRemarks though, so I don't think there is any way to click them, and they don't render as links in intelisense.
Co-authored-by: Jenn <jennle@microsoft.com>
jenn-le
approved these changes
Nov 1, 2024
CraigMacomber
commented
Nov 1, 2024
tylerbutler
added
the
release-blocking
noencke
approved these changes
Nov 1, 2024
Contributor
noencke
left a comment
noencke
left a comment
There was a problem hiding this comment.
Approved for API - alpha only
Josmithr
reviewed
Nov 1, 2024
Josmithr
reviewed
Nov 1, 2024
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
tylerbutler
pushed a commit
to tylerbutler/FluidFramework
that referenced
this pull request
Nov 4, 2024
## Description Added import/export options for tree content and schema, and example script using them.
Josmithr
pushed a commit
that referenced
this pull request
Nov 5, 2024
## Description Added import/export options for tree content and schema, and example script using them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added import/export options for tree content and schema, and example script using them.
Reviewer Guidance
The review process is outlined on this wiki page.