merge-tree: Add regression tests for bugs with zero length obliterate #22787
Merged
Conversation
github-actions
Bot
added
area: dds
| assert.equal(sharedString2.getText(), "01AAA2456789", "obliterate failed"); | ||
| }); | ||
|
|
||
| it.skip("zero length obliterate in the middle of the string", () => { |
Contributor
There was a problem hiding this comment.
This should be the only test. start and end are not supported, and the other tests don't actually test start and end anyway.
Collaborator
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: a754dfe |
|
|
||
| beforeEach(() => { | ||
| dataStoreRuntime1 = new MockFluidDataStoreRuntime(); | ||
| dataStoreRuntime1.options = { |
Contributor
There was a problem hiding this comment.
Rather than enable for all the existing tests in this describe block, can you create a new one?
scarlettjlee
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the sided obliterate function in shared string fails currently with two different errors:
0x2d8: Empty change event should not be emitted0x045: On insert, seq number already assigned!Tests in
sharedString.spec.tscurrently repro the0x2d8error only.AB#19742