feat(build-tools): Add generate:node10Entrypoints command#22937
Conversation
github-actions
Bot
added
base: main
sonalideshpandemsft
force-pushed
the
node10-compat-cmd
branch
from
628b498 to
82bfb61
Compare
sonalideshpandemsft
force-pushed
the
node10-compat-cmd
branch
from
82bfb61 to
821fe4f
Compare
github-actions
Bot
removed
the
dependencies
sonalideshpandemsft
force-pushed
the
node10-compat-cmd
branch
from
03f390f to
d9fda6a
Compare
| import type { Node10CompatExportData } from "../../library/packageExports.js"; | ||
| import type { CommandLogger } from "../../logging.js"; | ||
|
|
||
| export default class GenerateNode10EntrypointsCommand extends BaseCommand< |
There was a problem hiding this comment.
nit: not a blocker. Ideally either the path to the folder or package.json would be a flag, even if it has a default
value. Makes it easier to test. But it can always be added later.
tylerbutler
left a comment
tylerbutler
left a comment
There was a problem hiding this comment.
Approved. I suggest adding these two input flags from the existing command: --outDir and --mainEntrypoint. Those will give us more flexibility when we start using this. But no need to block on this if you do a follow-up. We could still get this merged as-is.
I think node10 will not require these flags. It only need the package exports. |
This PR add a new command to generate node10 type declaration entrypoints. Most of the node10 code is extracted from [generate entrypoint](https://github.com/microsoft/FluidFramework/blob/main/build-tools/packages/build-cli/src/library/commands/generateEntrypoints.ts) command.
2 participants
This PR add a new command to generate node10 type declaration entrypoints. Most of the node10 code is extracted from generate entrypoint command.