Skip to content

doc(tree): move merge semantics doc to user-facing folder#22988

Merged
yann-achard-MS merged 1 commit into
microsoft:mainfrom
yann-achard-MS:move-merge-semantics-doc
Nov 6, 2024
Merged

doc(tree): move merge semantics doc to user-facing folder#22988
yann-achard-MS merged 1 commit into
microsoft:mainfrom
yann-achard-MS:move-merge-semantics-doc

Conversation

@yann-achard-MS
Copy link
Copy Markdown
Contributor

Description

Moves the merge semantics doc to user-facing folder.

@github-actions github-actions Bot added base: main PRs targeted against main branch area: dds Issues related to distributed data structures area: dds: tree labels Nov 5, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluidframework-docs@0.25.0 ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> fluidframework-docs@0.25.0 ci:start
> http-server ./public --port 1313 --silent


> fluidframework-docs@0.25.0 linkcheck:full
> npm run linkcheck:fast -- --external


> fluidframework-docs@0.25.0 linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

Stats:
  447786 links
    3441 destination URLs
       2 URLs ignored
       0 warnings
       0 errors


Copy link
Copy Markdown
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

No packages impacted by the change.


Baseline commit: 7abf5cf
Baseline build: 304305
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Copy Markdown
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 464.21 KB 464.24 KB +35 Bytes
azureClient.js 562.45 KB 562.5 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 261.86 KB 261.87 KB +14 Bytes
fluidFramework.js 424.82 KB 424.84 KB +14 Bytes
loader.js 134.17 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 148.54 KB 148.55 KB +7 Bytes
odspClient.js 528.3 KB 528.34 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 164.76 KB 164.76 KB +7 Bytes
sharedTree.js 415.28 KB 415.29 KB +7 Bytes
Total Size 3.36 MB 3.36 MB +245 Bytes

Baseline commit: 7abf5cf

Generated by 🚫 dangerJS against 999cfa6

@yann-achard-MS yann-achard-MS merged commit e3ae396 into microsoft:main Nov 6, 2024
@jason-ha
Copy link
Copy Markdown
Contributor

jason-ha commented Nov 8, 2024

🔗 No broken links found! ✅

Your attention to detail is admirable.

@yann-achard-MS, while this says no broken links, the change has led to broken links.
See

You can also read more about how these editing operations work in collaborative settings [here](https://github.com/microsoft/FluidFramework/blob/main/packages/dds/tree/docs/main/merge-semantics.md).
that references the moved file.

@Josmithr, I guess the link checker should actually redirect repo main branch references to the source branch if we wanted to really confirm no breaks will result.

@yann-achard-MS
Copy link
Copy Markdown
Contributor Author

🔗 No broken links found! ✅
Your attention to detail is admirable.

@yann-achard-MS, while this says no broken links, the change has led to broken links. See

You can also read more about how these editing operations work in collaborative settings [here](https://github.com/microsoft/FluidFramework/blob/main/packages/dds/tree/docs/main/merge-semantics.md).

that references the moved file.
@Josmithr, I guess the link checker should actually redirect repo main branch references to the source branch if we wanted to really confirm no breaks will result.

Thanks for the heads up @jason-ha, here's the fix: #23047

yann-achard-MS added a commit that referenced this pull request Nov 11, 2024
## Description

Fix a link broken by
#22988.

## Breaking Changes

None
@yann-achard-MS yann-achard-MS deleted the move-merge-semantics-doc branch January 15, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants