docs(tree): merge semantics docs for each node kind#23040
Conversation
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: c7730cc |
alexvy86
left a comment
There was a problem hiding this comment.
Mostly minor notes, a few bits of more relevant feedback. Also, I think these docs really should find their way to fluidframework.com. cc @Josmithr @rohandubal
| When that's the case, | ||
| the items end up ordered such that the items inserted by the edit that is sequenced earlier will appear after the items inserted by the edits that is sequenced later. |
There was a problem hiding this comment.
Nit, the first line is shorter than it could be and the second one longer. (I'm assuming you split them based on known conventions like 80 char lines, or IDE rulers; that's what I normally do).
There was a problem hiding this comment.
No, I'm splitting based on gramatically independent clauses (whith the hope of making it easier to do line-by-line review).
For example I can't split that long line into a standalone clause.
There was a problem hiding this comment.
Interesting, I hadn't seen that approach before, but I can see the appeal.
There was a problem hiding this comment.
I do the same FWIW. I split on sentences, and if I have a very long sentence then I'll split over a comma, and if there are no commas then I'll do what Yann did. Though, I'm starting to let my lines be longer and longer these days. Both viewers and editors have line wrap if you want them, so often the only practical advantage to splitting up the lines is to reduce merge conflicts, and that just doesn't happen that often with doc files.
There was a problem hiding this comment.
Breaking on sentence boundaries is documented as a best practice in our github wiki.
https://github.com/microsoft/FluidFramework/wiki/Markdown-Best-Practices#line-breaks-along-sentence-boundaries
| Since Bob's client has yet to receive his own edit back from the sequencing service, | ||
| Bob's client can deduce that his edit is sequenced later and therefore wins out over Alice's. | ||
| This means the color property can remain blue.<br /> |
There was a problem hiding this comment.
Maybe add a footnote or something to indicate what would happen if Bob's operation is NACKed? The color would go back to red, I... think/hope? 😄 .
Also, do we need the <br/> here and a few lines above?
There was a problem hiding this comment.
Actually, I don't think we support that in SharedTree. Once you've allowed an edit to be sent for sequencing, we forever re-try until you close the session.
I agree that may not always be ideal.
There was a problem hiding this comment.
Just realized Github helpfully [cough] rendered the <br/>, so I think the question stands, do we actually need them in md files?
|
For the image files, if possible, we should avoid adding them directly to the repo. Alternative option: https://github.com/microsoft/FluidFramework/wiki/Uploading-images-for-the-website-to-Azure-blob-storage |
@Josmithr - is that the recommended approach even for docs that are not part of the website? It seems that the only docs that currently use this approach are from the root docs folder. |
It is, though we need to do a better job of documenting that (and why). I have an item on my plate for unifying some of the documentation around that. One of the primary objectives is to reduce the number of binary files we check in to the repo. |
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Description
Adds documentation describing the merge semantics of operations on each node kind in the tree.
Breaking Changes
None