chore(tree): Simplify getAllowedContentIncompatibilities output#23041
Merged
Conversation
github-actions
Bot
added
area: dds
msfluid-bot
reviewed
Nov 8, 2024
Collaborator
msfluid-bot
left a comment
msfluid-bot
left a comment
There was a problem hiding this comment.
Code Coverage Summary
↑ packages.dds.tree.src.feature-libraries.modular-schema:
Line Coverage Change: 0.04% Branch Coverage Change: 0.08%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 93.01% | 93.09% | ↑ 0.08% |
| Line Coverage | 95.06% | 95.10% | ↑ 0.04% |
Baseline commit: aa84db1
Baseline build: 305550
Happy Coding!!
Code coverage comparison check passed!!
Collaborator
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: aa84db1 |
taylorsw04
approved these changes
Nov 12, 2024
taylorsw04
reviewed
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous output allowed undefined in FieldKindIncompatibility instances where either the stored or view schema did not have some field implicitly. However, it is also possible to declare a field as not present explicitly using forbidden, which should be treated identically when considering compatibility. This updates the output representation as well as logic to normalize implicit cases to use forbidden.