Skip to content

refactor(tree): Promote eslint config from minimal base (deprecated) to recommended base#23042

Merged
Josmithr merged 11 commits into
microsoft:mainfrom
Josmithr:tree/eslint-config
Nov 9, 2024
Merged

refactor(tree): Promote eslint config from minimal base (deprecated) to recommended base#23042
Josmithr merged 11 commits into
microsoft:mainfrom
Josmithr:tree/eslint-config

Conversation

@Josmithr
Copy link
Copy Markdown
Contributor

@Josmithr Josmithr commented Nov 8, 2024

The minimal-deprecated config is scheduled for deletion. This PR migrates the tree package off of that config.

Fixes some of the simpler violations, but otherwise disables rules in the local config for future work to address.

AB#6983

@Josmithr Josmithr requested a review from taylorsw04 November 8, 2024 22:56
@github-actions github-actions Bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Nov 8, 2024
Copy link
Copy Markdown
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↓ packages.dds.tree.src.feature-libraries.modular-schema:
Line Coverage Change: No change    Branch Coverage Change: -0.01%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 93.01% 93.00% ↓ -0.01%
Line Coverage 95.06% 95.06% → No change
↑ packages.dds.tree.src.simple-tree:
Line Coverage Change: No change    Branch Coverage Change: 0.01%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 94.06% 94.07% ↑ 0.01%
Line Coverage 97.21% 97.21% → No change
↑ packages.dds.tree.src.shared-tree:
Line Coverage Change: No change    Branch Coverage Change: 0.03%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 90.85% 90.88% ↑ 0.03%
Line Coverage 97.28% 97.28% → No change

Baseline commit: aa84db1
Baseline build: 305550
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Copy Markdown
Collaborator

@fluid-example/bundle-size-tests: +451 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 463.74 KB 463.77 KB +35 Bytes
azureClient.js 562.69 KB 562.74 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 261.99 KB 262 KB +14 Bytes
fluidFramework.js 426.55 KB 426.66 KB +117 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 148.32 KB 148.33 KB +7 Bytes
odspClient.js 528.43 KB 528.48 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 164.17 KB 164.17 KB +7 Bytes
sharedTree.js 417.01 KB 417.11 KB +110 Bytes
Total Size 3.36 MB 3.36 MB +451 Bytes

Baseline commit: aa84db1

Generated by 🚫 dangerJS against 67eaa36

@Josmithr Josmithr marked this pull request as ready for review November 8, 2024 23:59
@Josmithr Josmithr requested a review from a team as a code owner November 8, 2024 23:59
@Josmithr Josmithr merged commit 92515fa into microsoft:main Nov 9, 2024
@Josmithr Josmithr deleted the tree/eslint-config branch November 9, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants