refactor(tree): Promote eslint config from minimal base (deprecated) to recommended base#23042
Merged
Merged
Conversation
Disables rules with existing violations. These will need to be fixed in subsequent PRs.
msfluid-bot
reviewed
Nov 8, 2024
Collaborator
msfluid-bot
left a comment
There was a problem hiding this comment.
Code Coverage Summary
↓ packages.dds.tree.src.feature-libraries.modular-schema:
Line Coverage Change: No change Branch Coverage Change: -0.01%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 93.01% | 93.00% | ↓ -0.01% |
| Line Coverage | 95.06% | 95.06% | → No change |
↑ packages.dds.tree.src.simple-tree:
Line Coverage Change: No change Branch Coverage Change: 0.01%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 94.06% | 94.07% | ↑ 0.01% |
| Line Coverage | 97.21% | 97.21% | → No change |
↑ packages.dds.tree.src.shared-tree:
Line Coverage Change: No change Branch Coverage Change: 0.03%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 90.85% | 90.88% | ↑ 0.03% |
| Line Coverage | 97.28% | 97.28% | → No change |
Baseline commit: aa84db1
Baseline build: 305550
Happy Coding!!
Code coverage comparison check passed!!
Collaborator
⯅ @fluid-example/bundle-size-tests: +451 Bytes
Baseline commit: aa84db1 |
taylorsw04
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
minimal-deprecatedconfig is scheduled for deletion. This PR migrates the tree package off of that config.Fixes some of the simpler violations, but otherwise disables rules in the local config for future work to address.
AB#6983