docs: Add more ImplicitAllowedTypes docs#23045
Merged
Merged
Conversation
github-actions
Bot
added
area: dds
Josmithr
reviewed
Nov 9, 2024
noencke
reviewed
Nov 9, 2024
| * class A extends sf.array("example", [() => B]) {} | ||
| * class B extends sf.array("Inner", sf.number) {} | ||
| * ``` | ||
| * @public |
Contributor
There was a problem hiding this comment.
Do you think this should be a @System type? Even if so, I guess it's technically too late to change it...
Contributor
Author
There was a problem hiding this comment.
This type is used as an input to tons of public APIs. Making it system would be strange and make it hard to write generic functions for anything schema related without referencing it. It really seems like one of the most key types in the public schema API surface used in every place we support polymorphism. It is non system on purpose (and also to late to change if we wanted)
Josmithr
reviewed
Nov 9, 2024
Josmithr
approved these changes
Nov 9, 2024
Contributor
Josmithr
left a comment
Josmithr
left a comment
There was a problem hiding this comment.
These are great! Thank you for adding them!
Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com> Co-authored-by: Joshua Smithrud <54606601+Josmithr@users.noreply.github.com>
msfluid-bot
reviewed
Nov 9, 2024
Collaborator
msfluid-bot
left a comment
msfluid-bot
left a comment
There was a problem hiding this comment.
Code Coverage Summary
↑ packages.dds.tree.src.simple-tree:
Line Coverage Change: 0.02% Branch Coverage Change: No change
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 94.07% | 94.07% | → No change |
| Line Coverage | 97.21% | 97.23% | ↑ 0.02% |
Baseline commit: 92515fa
Baseline build: 305622
Happy Coding!!
Code coverage comparison check passed!!
Collaborator
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 92515fa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add more ImplicitAllowedTypes docs
Reviewer Guidance
The review process is outlined on this wiki page.