Odsp create new module#23049
Merged
anthony-murphy merged 18 commits intoNov 11, 2024
Merged
Conversation
…to prototype-rename-tmp-file
…to prototype-rename-tmp-file
…to prototype-rename-tmp-file
…to prototype-rename-tmp-file
…to prototype-rename-tmp-file
…to prototype-rename-tmp-file
…to prototype-rename-tmp-file
…to prototype-rename-tmp-file
…to odsp-create-new-module
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- packages/drivers/odsp-driver/src/odspDocumentServiceFactoryCore.ts: Evaluated as low risk
- packages/drivers/odsp-driver/src/createFile/createNewUtils.ts: Evaluated as low risk
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
msfluid-bot
reviewed
Nov 11, 2024
Collaborator
msfluid-bot
left a comment
There was a problem hiding this comment.
Code Coverage Summary
↑ packages.drivers.odsp-driver.src:
Line Coverage Change: -0.78% Branch Coverage Change: 0.94%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 85.33% | 86.27% | ↑ 0.94% |
| Line Coverage | 74.90% | 74.12% | ↓ -0.78% |
↑ packages.drivers.odsp-driver.src.createFile:
Line Coverage Change: 88.34% Branch Coverage Change: 71.92%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 0.00% | 71.92% | ↑ 71.92% |
| Line Coverage | 0.00% | 88.34% | ↑ 88.34% |
↑ packages.drivers.odsp-driver.src.createFile:
Line Coverage Change: 88.34% Branch Coverage Change: 71.92%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 0.00% | 71.92% | ↑ 71.92% |
| Line Coverage | 0.00% | 88.34% | ↑ 88.34% |
Baseline commit: 3c27751
Baseline build: 305767
Happy Coding!!
Code coverage comparison check passed!!
Collaborator
⯅ @fluid-example/bundle-size-tests: +373 Bytes
Baseline commit: 3c27751 |
jatgarg
reviewed
Nov 11, 2024
jatgarg
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change takes the existing logic to load the createNewModule and encapsulates it in a function to make it more reusable, and less error prone.
The primary motivation for this change is that in an upcoming change I'll want to use the createNewModule and don't want to duplicate the existing logic
By moving the files of the createNewModule under a folder, and not exporting them directly, it makes it clearer that they should not be directly imported.