MergeTree: Remove SegmentGroup from internal#23401
Merged
anthony-murphy merged 4 commits intoJan 2, 2025
Merged
Conversation
github-actions
Bot
added
area: dds
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- packages/dds/matrix/src/matrix.ts: Evaluated as low risk
- packages/dds/matrix/src/permutationvector.ts: Evaluated as low risk
- packages/dds/merge-tree/src/client.ts: Evaluated as low risk
- packages/dds/merge-tree/src/index.ts: Evaluated as low risk
- packages/dds/merge-tree/src/mergeTree.ts: Evaluated as low risk
- packages/dds/merge-tree/src/mergeTreeNodes.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
packages/dds/merge-tree/src/segmentGroupCollection.ts:42
- The method name 'pop?' should not have a question mark. It should be 'pop'.
public pop?(): SegmentGroup | undefined {
anthony-murphy
changed the title
jzaffiro
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes SegmentGroup, and a few other types from the internal api. This exposure was unnecessary, as internal consumer just need
localOpMetadatawhich is anunknown, so the existing internal consumers do not need the type. Additionally, this change will make some additional refactoring around deprecated segment properties easier to stage.