Skip to content

Conversation

@alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Mar 25, 2025

Description

Updating fluid build task dependencies per Abram's suggestion so building the bundle-size-tests package locally results in a state where the tests can actually run and succeed.

The webpack task already depends on build:esnext in the base fluid build config so the entry here was somewhat redundant, but also it prevented the build:test -> webpack dependency because it caused circular task dependencies.

I confirmed this now works locally; after running pnpm build, pnpm test successfully runs the tests and they pass. Of note, pnpm build:test is not enough to make that work because that just runs the build:test npm script which does not cause fluid-build to run. On the other hand, the build npm script invokes fluid-build and all the dependencies work correctly.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings March 25, 2025 17:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • examples/utils/bundle-size-tests/package.json: Language not supported

@alexvy86 alexvy86 changed the title Update fluid build task deps build(bundle-size-tests): Update fluid build task deps Mar 25, 2025
@github-actions github-actions bot added base: main PRs targeted against main branch area: examples Changes that focus on our examples labels Mar 25, 2025
@alexvy86 alexvy86 requested review from a team, Abe27342 and CraigMacomber March 25, 2025 17:44
@alexvy86
Copy link
Contributor Author

Closing in favor of #24162

@alexvy86 alexvy86 closed this Mar 31, 2025
@alexvy86 alexvy86 deleted the update-build-task-deps branch March 31, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: examples Changes that focus on our examples base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant