build(bundle-size-tests): Update fluid build task deps #24146
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating fluid build task dependencies per Abram's suggestion so building the bundle-size-tests package locally results in a state where the tests can actually run and succeed.
The
webpacktask already depends onbuild:esnextin the base fluid build config so the entry here was somewhat redundant, but also it prevented thebuild:test -> webpackdependency because it caused circular task dependencies.I confirmed this now works locally; after running
pnpm build,pnpm testsuccessfully runs the tests and they pass. Of note,pnpm build:testis not enough to make that work because that just runs thebuild:testnpm script which does not cause fluid-build to run. On the other hand, thebuildnpm script invokes fluid-build and all the dependencies work correctly.Reviewer Guidance
The review process is outlined on this wiki page.