Skip to content

Remove FluidDataStoreContext.request#24293

Merged
ChumpChief merged 3 commits intomicrosoft:mainfrom
ChumpChief:NoRequestContext
Apr 9, 2025
Merged

Remove FluidDataStoreContext.request#24293
ChumpChief merged 3 commits intomicrosoft:mainfrom
ChumpChief:NoRequestContext

Conversation

@ChumpChief
Copy link
Copy Markdown
Contributor

This is internal and has been deprecated for a long time. Seems safe to remove.

Also removes some use of mixinRequestHandler from prosemirror/codemirror, since they don't actually issue requests in those demos.

@github-actions github-actions Bot added area: examples Changes that focus on our examples area: runtime Runtime related issues dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Apr 9, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • examples/data-objects/codemirror/package.json: Language not supported
  • examples/data-objects/prosemirror/package.json: Language not supported
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)

packages/runtime/container-runtime/src/dataStoreContext.ts:796

  • Ensure that tests are updated to reflect the removal of FluidDataStoreContext.request so that downstream behavior is not inadvertently affected.
public async request(request: IRequest): Promise<IResponse> {

examples/data-objects/prosemirror/src/prosemirror.tsx:110

  • Confirm that the removal of the request method and mixinRequestHandler does not affect demo functionality, and verify that tests cover the updated runtime instantiation.
public async request(req: IRequest): Promise<IResponse> {

examples/data-objects/codemirror/src/codeMirror.ts:83

  • Ensure that tests verify the demos function correctly after removing the request method and mixinRequestHandler usage.
public async request(req: IRequest): Promise<IResponse> {

@ChumpChief ChumpChief requested a review from kian-thompson April 9, 2025 16:35
@ChumpChief ChumpChief merged commit 5f19024 into microsoft:main Apr 9, 2025
33 checks passed
@ChumpChief ChumpChief deleted the NoRequestContext branch April 9, 2025 17:39
WillieHabi added a commit to WillieHabi/FluidFramework that referenced this pull request Apr 10, 2025
WillieHabi added a commit to WillieHabi/FluidFramework that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: examples Changes that focus on our examples area: runtime Runtime related issues base: main PRs targeted against main branch dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants