Remove FluidDataStoreContext.request#24293
Merged
ChumpChief merged 3 commits intomicrosoft:mainfrom Apr 9, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (3)
- examples/data-objects/codemirror/package.json: Language not supported
- examples/data-objects/prosemirror/package.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)
packages/runtime/container-runtime/src/dataStoreContext.ts:796
- Ensure that tests are updated to reflect the removal of FluidDataStoreContext.request so that downstream behavior is not inadvertently affected.
public async request(request: IRequest): Promise<IResponse> {
examples/data-objects/prosemirror/src/prosemirror.tsx:110
- Confirm that the removal of the request method and mixinRequestHandler does not affect demo functionality, and verify that tests cover the updated runtime instantiation.
public async request(req: IRequest): Promise<IResponse> {
examples/data-objects/codemirror/src/codeMirror.ts:83
- Ensure that tests verify the demos function correctly after removing the request method and mixinRequestHandler usage.
public async request(req: IRequest): Promise<IResponse> {
anthony-murphy
approved these changes
Apr 9, 2025
WillieHabi
added a commit
to WillieHabi/FluidFramework
that referenced
this pull request
Apr 10, 2025
This reverts commit 5f19024. revert old commit
WillieHabi
added a commit
to WillieHabi/FluidFramework
that referenced
this pull request
Apr 12, 2025
This reverts commit a143455. revert prosemirror
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is internal and has been deprecated for a long time. Seems safe to remove.
Also removes some use of mixinRequestHandler from prosemirror/codemirror, since they don't actually issue requests in those demos.