Skip to content

Consumed new denyList into Historian#24315

Merged
dhr-verma merged 9 commits intomicrosoft:mainfrom
dhr-verma:vermadhr/alfredDenyList
Apr 10, 2025
Merged

Consumed new denyList into Historian#24315
dhr-verma merged 9 commits intomicrosoft:mainfrom
dhr-verma:vermadhr/alfredDenyList

Conversation

@dhr-verma
Copy link
Copy Markdown
Contributor

Description

Follow-up PR to #24298 to consume the new denyList into Historian. Replaces the old denyList implementation.

Copilot AI review requested due to automatic review settings April 10, 2025 18:54
@github-actions github-actions Bot added area: server Server related issues (routerlicious) base: main PRs targeted against main branch labels Apr 10, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 23 out of 26 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • server/gitrest/packages/gitrest-base/package.json: Language not supported
  • server/gitrest/pnpm-lock.yaml: Language not supported
  • server/historian/packages/historian-base/package.json: Language not supported
Comments suppressed due to low confidence (1)

server/historian/packages/historian-base/src/runnerFactory.ts:222

  • Verify that the new DenyList constructor parameters (tenantsDenyListConfig and documentsDenyListConfig) are passed in the correct order as expected by its updated signature; any mismatch could lead to unintended configuration behavior.
const documentsDenyListConfig = config.get("documentDenyList");

@dhr-verma dhr-verma enabled auto-merge (squash) April 10, 2025 18:56
@dhr-verma dhr-verma merged commit aa254a2 into microsoft:main Apr 10, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: server Server related issues (routerlicious) base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants