build(client): Tag asserts for release 2.32.0 #24349
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build for release 2.32.0 by replacing string-based assertion messages with numeric error codes throughout the codebase.
- Replaced literal error message strings with corresponding numeric code values in assertions.
- Updated the central assertion short code map by adding new entries and removing obsolete ones.
- Adjusted assertion calls in runtime, container, tree, and merge-tree/client modules to reference the new error codes.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts | Updated error mapping with new numeric codes and removed obsolete entries. |
| packages/runtime/container-runtime/src/opLifecycle/outbox.ts | Switched assertion error message to error code 0xb7b. |
| packages/runtime/container-runtime/src/opLifecycle/opGroupingManager.ts | Replaced assertion string messages with error codes 0xb79 and 0xb7a. |
| packages/runtime/container-runtime/src/opLifecycle/opCompressor.ts | Updated assertion to use error code 0xb78. |
| packages/dds/tree/src/simple-tree/core/unhydratedFlexTree.ts | Updated assertion in tree node parent check to error code 0xb77. |
| packages/dds/tree/src/simple-tree/core/treeNodeKernel.ts | Adjusted assertion to error code 0xb76. |
| packages/dds/tree/src/shared-tree/sharedTree.ts | Changed assertion in processCore to use error code 0xb75. |
| packages/dds/merge-tree/src/mergeTree.ts | Replaced string asserts with respective error codes (0xb6e, 0xb6f, 0xb70, 0xb71, 0xb72, 0xb73, 0xb74) for various conditions. |
| packages/dds/merge-tree/src/client.ts | Multiple assertions updated to reference error codes (0xb61 through 0xb6d, 0xb68, 0xb69, 0xb6b, 0xb6c) instead of descriptive strings. |
CraigMacomber
approved these changes
Apr 14, 2025
Abe27342
approved these changes
Apr 14, 2025
tylerbutler
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build(client): Tag asserts for release 2.32.0