Skip to content

build(client): Tag asserts for release 2.32.0 #24349

Merged
jatgarg merged 8 commits into
microsoft:mainfrom
jatgarg:asserts
Apr 14, 2025
Merged

build(client): Tag asserts for release 2.32.0 #24349
jatgarg merged 8 commits into
microsoft:mainfrom
jatgarg:asserts

Conversation

@jatgarg
Copy link
Copy Markdown
Contributor

@jatgarg jatgarg commented Apr 14, 2025

build(client): Tag asserts for release 2.32.0

@jatgarg jatgarg self-assigned this Apr 14, 2025
Copilot AI review requested due to automatic review settings April 14, 2025 17:37
@jatgarg jatgarg requested review from a team as code owners April 14, 2025 17:37
@github-actions github-actions Bot added base: main PRs targeted against main branch area: dds Issues related to distributed data structures area: dds: tree area: runtime Runtime related issues labels Apr 14, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the build for release 2.32.0 by replacing string-based assertion messages with numeric error codes throughout the codebase.

  • Replaced literal error message strings with corresponding numeric code values in assertions.
  • Updated the central assertion short code map by adding new entries and removing obsolete ones.
  • Adjusted assertion calls in runtime, container, tree, and merge-tree/client modules to reference the new error codes.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts Updated error mapping with new numeric codes and removed obsolete entries.
packages/runtime/container-runtime/src/opLifecycle/outbox.ts Switched assertion error message to error code 0xb7b.
packages/runtime/container-runtime/src/opLifecycle/opGroupingManager.ts Replaced assertion string messages with error codes 0xb79 and 0xb7a.
packages/runtime/container-runtime/src/opLifecycle/opCompressor.ts Updated assertion to use error code 0xb78.
packages/dds/tree/src/simple-tree/core/unhydratedFlexTree.ts Updated assertion in tree node parent check to error code 0xb77.
packages/dds/tree/src/simple-tree/core/treeNodeKernel.ts Adjusted assertion to error code 0xb76.
packages/dds/tree/src/shared-tree/sharedTree.ts Changed assertion in processCore to use error code 0xb75.
packages/dds/merge-tree/src/mergeTree.ts Replaced string asserts with respective error codes (0xb6e, 0xb6f, 0xb70, 0xb71, 0xb72, 0xb73, 0xb74) for various conditions.
packages/dds/merge-tree/src/client.ts Multiple assertions updated to reference error codes (0xb61 through 0xb6d, 0xb68, 0xb69, 0xb6b, 0xb6c) instead of descriptive strings.

@jatgarg jatgarg enabled auto-merge (squash) April 14, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dds: tree area: dds Issues related to distributed data structures area: runtime Runtime related issues base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants