AzureClient: Fix test issue#24537
Merged
anthony-murphy merged 1 commit intomicrosoft:mainfrom May 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses a test issue by updating the string literal used as a type identifier in the TestDataObjectFactory to a shared constant. This change aims to improve consistency by referencing TestDataObjectClass.Name instead of using a hard-coded string.
- Updated the type property in the DataObjectFactory from a literal string to TestDataObjectClass.Name.
- Helps mitigate discrepancies between tests by aligning with the naming in ephemeralSummaryTrees.ts.
Comments suppressed due to low confidence (1)
packages/service-clients/end-to-end-tests/azure-client/src/test/TestDataObject.ts:23
- Using a constant for the type improves maintainability. Please ensure that the equivalent hard-coded string in ephemeralSummaryTrees.ts is also updated to use TestDataObjectClass.Name to avoid test discrepancies.
type: TestDataObjectClass.Name,
scottn12
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #24527 a test issue was identified in the AzureClient. The problem was the rename of a string, which shouldn't necessarily matter, but in this case the string is also hard coded in another file: packages\service-clients\end-to-end-tests\azure-client\src\test\ephemeralSummaryTrees.ts