Skip to content

AzureClient: Fix test issue#24537

Merged
anthony-murphy merged 1 commit intomicrosoft:mainfrom
anthony-murphy:fix-test
May 7, 2025
Merged

AzureClient: Fix test issue#24537
anthony-murphy merged 1 commit intomicrosoft:mainfrom
anthony-murphy:fix-test

Conversation

@anthony-murphy
Copy link
Copy Markdown
Contributor

@anthony-murphy anthony-murphy commented May 7, 2025

In #24527 a test issue was identified in the AzureClient. The problem was the rename of a string, which shouldn't necessarily matter, but in this case the string is also hard coded in another file: packages\service-clients\end-to-end-tests\azure-client\src\test\ephemeralSummaryTrees.ts

Copilot AI review requested due to automatic review settings May 7, 2025 16:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses a test issue by updating the string literal used as a type identifier in the TestDataObjectFactory to a shared constant. This change aims to improve consistency by referencing TestDataObjectClass.Name instead of using a hard-coded string.

  • Updated the type property in the DataObjectFactory from a literal string to TestDataObjectClass.Name.
  • Helps mitigate discrepancies between tests by aligning with the naming in ephemeralSummaryTrees.ts.
Comments suppressed due to low confidence (1)

packages/service-clients/end-to-end-tests/azure-client/src/test/TestDataObject.ts:23

  • Using a constant for the type improves maintainability. Please ensure that the equivalent hard-coded string in ephemeralSummaryTrees.ts is also updated to use TestDataObjectClass.Name to avoid test discrepancies.
type: TestDataObjectClass.Name,

@github-actions github-actions bot added the base: main PRs targeted against main branch label May 7, 2025
@anthony-murphy anthony-murphy enabled auto-merge (squash) May 7, 2025 16:24
@anthony-murphy anthony-murphy merged commit 517af87 into microsoft:main May 7, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants