Allow specifying primary registry in include-install-pnpm.yaml #25540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying a primary npm registry parameter in the include-install-pnpm.yaml pipeline template, enabling different stages to use different registries for package installation.
- Adds a new
primaryRegistryparameter to the pnpm install template with a sensible default - Updates the telemetry upload stage to use a download-only feed instead of the default primary registry
- Replaces hardcoded registry variable references with the parameterized value
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/pipelines/templates/include-install-pnpm.yml | Adds primaryRegistry parameter and updates environment variable references to use the parameter |
| tools/pipelines/templates/include-upload-stage-telemetry.yml | Specifies download-only feed as the primary registry for the telemetry upload stage |
github-actions
bot
added
area: build
jzaffiro
approved these changes
Sep 24, 2025
…to test/absander/spec-primary-registry
jzaffiro
approved these changes
Sep 24, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
…soft#25540) ## Description Follow-up to microsoft#25535 that allows specifying the primary registry in `include-install-pnpm.yaml` so that the telemetry stage upload template can reference the feed we use to install internal packages. Test run [here](https://dev.azure.com/fluidframework/internal/_build/results?buildId=357059&view=logs&j=7ef2f12f-27d7-5730-657b-d3ad5f630362&t=9da23dd1-2e0f-578e-ea27-ee9162e0f22c). Co-authored-by: Abram Sanderson <absander@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #25535 that allows specifying the primary registry in
include-install-pnpm.yamlso that the telemetry stage upload template can reference the feed we use to install internal packages.Test run here.