Add minimal text domain #26060
Merged
Add minimal text domain #26060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a minimal internal text domain for the tree DDS, providing schema and utilities for building text editors beyond basic string primitives. The implementation stores text as an array of individual characters and exposes a simple API for text manipulation operations.
Key Changes:
- Adds
TextAsTreenamespace with schema for representing text as a tree structure - Implements basic text editing operations (insert, remove, iterate characters)
- Includes initial test coverage for basic functionality
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dds/tree/src/text/textDomain.ts | Core implementation defining TextNode class with character array storage and editing methods |
| packages/dds/tree/src/text/index.ts | Public export of TextAsTree namespace |
| packages/dds/tree/src/text/README.md | Documentation noting early work-in-progress status |
| packages/dds/tree/src/test/text/textDomain.spec.ts | Basic tests for text node type validation and common operations |
| packages/dds/tree/src/index.ts | Adds TextAsTree to main package exports |
brrichards
approved these changes
Jan 7, 2026
Josmithr
reviewed
Jan 7, 2026
Josmithr
reviewed
Jan 7, 2026
Josmithr
reviewed
Jan 7, 2026
| * - Support in generateSchemaFromSimpleSchema for recognizing text nodes and generating the appropriate schema. | ||
| * - Ensure above features work well enough to support important scenarios like AI assisted editing and document indexing for search. | ||
| * | ||
| * Again these are general patterns that components with non-trivial encodings and thus part of that work will be establishing and documenting those patterns more generally, |
Contributor
There was a problem hiding this comment.
There seems to be a typo in this sentence. I'm having trouble parsing it.
Josmithr
reviewed
Jan 7, 2026
Josmithr
approved these changes
Jan 7, 2026
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Josmithr
approved these changes
Jan 7, 2026
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
## Description Add minimal internal only text domain suitable for building an example text editor or tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add minimal internal only text domain suitable for building an example text editor or tree.
Reviewer Guidance
The review process is outlined on this wiki page.