Skip to content

Conversation

@Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Jan 9, 2026

Also fixes resulting linter violations.

Part of a larger effort to collapse the "recommended" and "minimal-deprecated" configs and eventually delete the latter.

@Josmithr Josmithr requested a review from a team as a code owner January 9, 2026 22:37
Copilot AI review requested due to automatic review settings January 9, 2026 22:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes the jsdoc/multiline-blocks ESLint rule from the recommended configuration to the minimal configuration as part of a larger effort to consolidate eslint configs and eventually deprecate the minimal-deprecated config.

  • Moves the jsdoc/multiline-blocks rule from recommended.js to minimal-deprecated.js
  • Updates the generated minimal config JSON
  • Fixes JSDoc formatting violations across 4 files to comply with the newly-enforced rule
  • Documents the rule promotion in the CHANGELOG

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
common/build/eslint-config-fluid/recommended.js Removes jsdoc/multiline-blocks rule definition (now inherited from minimal)
common/build/eslint-config-fluid/minimal-deprecated.js Adds jsdoc/multiline-blocks rule to minimal configuration
common/build/eslint-config-fluid/printed-configs/minimal.json Updates generated minimal config with the new rule
common/build/eslint-config-fluid/CHANGELOG.md Documents the rule promotion from recommended to minimal
experimental/dds/tree/src/test/HistoryEditFactory.tests.ts Fixes JSDoc block comment to use proper multiline format
experimental/PropertyDDS/packages/property-properties/src/properties/valueMapProperty.js Fixes JSDoc constructor comment to use proper multiline format
experimental/PropertyDDS/packages/property-properties/src/properties/valueArrayProperty.js Fixes two JSDoc constructor comments to use proper multiline format
experimental/PropertyDDS/packages/property-changeset/src/changeset_operations/changesetConflictTypes.ts Fixes JSDoc enum value comment to use proper multiline format

@Josmithr Josmithr enabled auto-merge (squash) January 12, 2026 17:38
@github-actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  248785 links
    1796 destination URLs
    2036 URLs ignored
       0 warnings
       0 errors


@Josmithr Josmithr merged commit d18c214 into microsoft:main Jan 12, 2026
37 checks passed
@Josmithr Josmithr deleted the eslint-config-fluid/promote-jsdoc-multiline branch January 12, 2026 19:04
anthony-murphy-agent pushed a commit to anthony-murphy-agent/FluidFramework that referenced this pull request Jan 14, 2026
… `recommended` to `minimal` (microsoft#26174)

Also fixes resulting linter violations.

Part of a larger effort to collapse the "recommended" and
"minimal-deprecated" configs and eventually delete the latter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants