Enable no-useless-fallback-in-spread in packages/tree #26177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the ESLint rule unicorn/no-useless-fallback-in-spread for the @fluidframework/tree package by removing the rule override from both ESLint configuration files and fixing the three instances where unnecessary ?? {} fallbacks were used in spread operations.
Changes:
- Removed
unicorn/no-useless-fallback-in-spread: "off"from both eslint.config.mts and .eslintrc.cjs - Updated three spread operations to remove unnecessary
?? {}fallbacks, as spreadingundefinedis safe in JavaScript
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dds/tree/eslint.config.mts | Removed the rule override for unicorn/no-useless-fallback-in-spread |
| packages/dds/tree/.eslintrc.cjs | Removed the rule override for unicorn/no-useless-fallback-in-spread |
| packages/dds/tree/src/simple-tree/api/schemaFactoryBeta.ts | Removed unnecessary ?? {} fallback when spreading optional options parameter |
| packages/dds/tree/src/simple-tree/api/schemaFactoryAlpha.ts | Removed unnecessary ?? {} fallback when spreading optional options parameter |
| packages/dds/tree/src/feature-libraries/sequence-field/rebase.ts | Removed unnecessary ?? {} fallback when spreading potentially undefined remains property |
taylorsw04
approved these changes
Jan 12, 2026
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
Removes the unicorn/no-useless-fallback: off override from the @fluidframework/tree package and fixes the resulting errors. This is part of an ongoing effort to incrementally remove global ESLint rule overrides from eslint.config.mts and .eslintrc.cjs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the unicorn/no-useless-fallback: off override from the @fluidframework/tree package and fixes the resulting errors. This is part of an ongoing effort to incrementally remove global ESLint rule overrides from eslint.config.mts and .eslintrc.cjs.