Enable unicorn/no-new-array in packages/tree #26178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the unicorn/no-new-array ESLint rule for the @fluidframework/tree package by removing the rule override and fixing all violations. This is part of an ongoing effort to incrementally remove global ESLint rule overrides.
Changes:
- Removed
unicorn/no-new-array: offfrom both eslint.config.mts and .eslintrc.cjs - Renamed local test schema classes from
ArraytoArrayNodeto avoid shadowing the built-in Array constructor - Refactored
new Array(length).fill(value).map()patterns to useArray.from()with a mapper function
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dds/tree/eslint.config.mts | Removed the unicorn/no-new-array: off override |
| packages/dds/tree/.eslintrc.cjs | Removed the unicorn/no-new-array: off override |
| packages/dds/tree/src/test/snapshots/snapshotTestScenarios.ts | Renamed Array class to ArrayNode to avoid shadowing built-in Array |
| packages/dds/tree/src/test/shared-tree/tree.spec.ts | Renamed Array class to ArrayNode to avoid shadowing built-in Array |
| packages/dds/tree/src/test/shared-tree/opSize.bench.ts | Refactored new Array(length).fill() to Array.from({ length }, mapper) |
| packages/dds/tree/src/test/domains/json/canada.ts | Refactored new Array(length).fill().map() to Array.from({ length }, mapper) |
noencke
approved these changes
Jan 12, 2026
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
Removes the unicorn/no-new-array: off override from the @fluidframework/tree package and fixes the resulting errors. This is part of an ongoing effort to incrementally remove global ESLint rule overrides from eslint.config.mts and .eslintrc.cjs. Renamed local schema classes from Array to ArrayNode to avoid shadowing the built-in Array constructor. These were false positives. All violations were fixed without requiring eslint-disable comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the unicorn/no-new-array: off override from the @fluidframework/tree package and fixes the resulting errors. This is part of an ongoing effort to incrementally remove global ESLint rule overrides from eslint.config.mts and .eslintrc.cjs.
Renamed local schema classes from Array to ArrayNode to avoid shadowing the built-in Array constructor. These were false positives.
All violations were fixed without requiring eslint-disable comments.