Enable unicorn/no-await-expression-member in packages/tree #26179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enables the unicorn/no-await-expression-member ESLint rule for the @fluidframework/tree package by removing the override from both ESLint configuration files and refactoring code to comply with the rule. The rule enforces extracting awaited values into intermediate variables before accessing their members, which improves code readability and debuggability.
Changes:
- Removed
unicorn/no-await-expression-member: "off"from botheslint.config.mtsand.eslintrc.cjs - Refactored test code to extract awaited values into intermediate variables before member access
- Updated the
getIIDCompressorfunction to use clearer control flow
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/dds/tree/eslint.config.mts | Removed the ESLint rule override for unicorn/no-await-expression-member |
| packages/dds/tree/.eslintrc.cjs | Removed the ESLint rule override for unicorn/no-await-expression-member |
| packages/dds/tree/src/test/shared-tree/sharedTree.spec.ts | Extracted awaited values into intermediate variables before accessing their .summary or other members in multiple test cases |
| packages/dds/tree/src/test/feature-libraries/node-identifier/nodeIdentifier.spec.ts | Refactored getIIDCompressor to avoid member access on awaited expression by using conditional logic |
packages/dds/tree/src/test/feature-libraries/node-identifier/nodeIdentifier.spec.ts
Outdated
Show resolved
Hide resolved
brrichards
force-pushed
the
enable-no-await-expression-member
branch
from
c7052a3 to
8bf8c07
Compare
taylorsw04
approved these changes
Jan 12, 2026
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
…#26179) Removes the unicorn/no-await-expression-member: off override from the @fluidframework/tree package and fixes the resulting errors. Extracts awaited values into intermediate variables before accessing their members. This is part of an ongoing effort to incrementally remove global ESLint rule overrides from eslint.config.mts and .eslintrc.cjs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the unicorn/no-await-expression-member: off override from the @fluidframework/tree package and fixes the resulting errors. Extracts awaited values into intermediate variables before accessing their members. This is part of an ongoing effort to incrementally remove global ESLint rule overrides from eslint.config.mts and .eslintrc.cjs.