Skip to content

Conversation

@brrichards
Copy link
Contributor

  • Renamed inventoryList.tsx to inventoryView.tsx in view folder.
  • Removed ESlint disable by adding an index.ts in view folder and importing from there

Copilot AI review requested due to automatic review settings January 12, 2026 21:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a cleanup of the inventory-app example by renaming inventoryList.tsx to inventoryView.tsx in the view folder and creating a barrel export file (index.ts) to centralize exports, thereby eliminating the need for ESLint disable comments when importing from the view directory.

Changes:

  • Renamed inventoryList.tsx to inventoryView.tsx for better naming consistency
  • Added index.ts barrel export file in the view folder
  • Updated import statements to use the new file structure and removed ESLint disable comment

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
examples/data-objects/inventory-app/src/view/inventoryView.tsx New file containing the renamed view components (previously inventoryList.tsx)
examples/data-objects/inventory-app/src/view/index.ts New barrel export file that exports Counter, ICounterProps, MainView, InventoryViewMonolithic, and InventoryViewWithHook
examples/data-objects/inventory-app/src/test/inventoryApp.test.tsx Updated import path from inventoryList.js to inventoryView.js
examples/data-objects/inventory-app/src/index.ts Updated to import from view/index.js and removed ESLint disable comment

@brrichards brrichards merged commit d513f6d into microsoft:main Jan 13, 2026
34 checks passed
anthony-murphy-agent pushed a commit to anthony-murphy-agent/FluidFramework that referenced this pull request Jan 14, 2026
- Renamed inventoryList.tsx to inventoryView.tsx in view folder. 
- Removed ESlint disable by adding an index.ts in view folder and
importing from there
@brrichards brrichards deleted the inventory-example-cleanup branch January 16, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants