feat(eslint-config-fluid): Enable "recommended" rules in "minimal-deprecated" as warnings #26190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recated" as warnings
Contributor
There was a problem hiding this comment.
Pull request overview
This PR promotes ESLint rules from the "recommended" configuration to the "minimal-deprecated" configuration as warnings, as part of a larger effort to collapse these configs. The changes enable stricter TypeScript type-checking and code quality rules in the minimal config while keeping them as warnings to avoid breaking existing builds.
Changes:
- Promoted 12 TypeScript and general ESLint rules from "recommended" to "minimal-deprecated" as warnings
- Added documentation comments for the newly enabled rules
- Reorganized the config file structure with proper region markers
- Removed redundant "off" declarations for rules now explicitly enabled
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
common/build/eslint-config-fluid/minimal-deprecated.js |
Added 12 rules as warnings with documentation, including type-safety rules (no-explicit-any, no-unsafe-*), import/export consistency rules, and code quality rules |
common/build/eslint-config-fluid/printed-configs/minimal.json |
Generated configuration file reflecting the changes in minimal-deprecated.js with resolved rule settings |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tylerbutler
approved these changes
Jan 13, 2026
Josmithr
deleted the
eslint-config-fluid/recommended-rules-in-minimal-as-warnings
branch
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
…recated" as warnings (microsoft#26190) Part of a larger effort to collapse "recommended" into "minimal-deprecated" so we can remove the "minimal" config from the package. Promotes rules explicitly enabled in "recommended" to "minimal" as warnings (for now). This will encourage developers to not introduce new violations and potentially fix existing ones while we do the larger config migration. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a larger effort to collapse "recommended" into "minimal-deprecated" so we can remove the "minimal" config from the package.
Promotes rules explicitly enabled in "recommended" to "minimal" as warnings (for now). This will encourage developers to not introduce new violations and potentially fix existing ones while we do the larger config migration.