Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the MAI “telemetry” extension to the devcontainer/Codespaces image and recommends it via workspace extension recommendations.
Changes:
- Recommend
MAI-EngineeringSystems.mai-ai-telemetryin.vscode/extensions.json - Preinstall
MAI-EngineeringSystems.mai-ai-telemetryin the devcontainer (.devcontainer/devcontainer.json)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .vscode/extensions.json | Adds MAI telemetry extension to workspace recommendations |
| .devcontainer/devcontainer.json | Adds MAI telemetry extension to devcontainer preinstalled extensions |
| "biomejs.biome", | ||
| "dbaeumer.vscode-eslint", | ||
| "esbenp.prettier-vscode", | ||
| "MAI-EngineeringSystems.mai-ai-telemetry", |
There was a problem hiding this comment.
This recommends an extension that appears to include telemetry by design (mai-ai-telemetry). Recommending telemetry-related extensions to all workspace users can have privacy/compliance implications. Consider adding brief documentation (e.g., in a README/CONTRIBUTING) explaining what data is collected (or confirming it collects none), whether it’s required, and how to disable/opt out; alternatively, avoid recommending it broadly and keep it Codespaces/devcontainer-only if it’s not strictly needed for local development.
Suggested change
| "MAI-EngineeringSystems.mai-ai-telemetry", |
taylorsw04
approved these changes
Feb 26, 2026
frankmueller-msft
added a commit
to frankmueller-msft/FluidFramework
that referenced
this pull request
Feb 26, 2026
Remove trailing comma after last extension entry that biome 2.x flags as a formatting error. This was introduced in microsoft#26547 and is causing biome check failures across all PR builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
markfields
pushed a commit
that referenced
this pull request
Feb 26, 2026
## Description With this change: [Pull request](#26547), there was a format error that was added to `devcontainer.json`. ## Reviewer Guidance The review process is outlined on [this wiki page](https://github.com/microsoft/FluidFramework/wiki/PR-Guidelines#guidelines).
frankmueller-msft
added a commit
to frankmueller-msft/FluidFramework
that referenced
this pull request
Feb 26, 2026
Files like .devcontainer/devcontainer.json and .vscode/extensions.json are formatted by biome but were not in the build-client pipeline trigger paths. PRs that only touch these files skip the format check, allowing formatting errors to merge (e.g. PR microsoft#26547 → fix PR microsoft#26565). Add .devcontainer/*, .vscode/*, .pnpmfile.cjs, _buildProject.config.cjs, and assertTagging.config.mjs to both trigger and pr path includes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
frankmueller-msft
added a commit
that referenced
this pull request
Feb 26, 2026
## Summary PR #26547 changed `.devcontainer/devcontainer.json` and `.vscode/extensions.json` but no CI pipeline checked formatting, allowing a trailing comma error to merge (fixed by PR #26565). **Root cause:** `biome check .` (run by `check:format:repo`) covers the entire repo, but no pipeline was running it on every PR. The `build-client` pipeline only triggers on specific paths, and `.devcontainer/` and `.vscode/` weren't included. **Fix (two parts):** 1. **`repo-policy-check.yml`** — Add `check:format:repo` step (`biome check .`). This pipeline runs on every PR with no path filter, so formatting is always validated regardless of which files change. Note: `npm run checks` (the broader check) can't be used here because it depends on `fluid-build`/`flub` and full workspace deps, but this pipeline only installs root deps. `policy-check` and `layer-check` already run as separate steps. 2. **`build-client.yml`** — Add missing root-level config files that biome formats to the trigger paths: - `.pnpmfile.cjs` - `_buildProject.config.cjs` - `assertTagging.config.mjs` ## Test plan - [ ] Verify the pipeline YAML is valid (no syntax errors) - [ ] Confirm `repo-policy-check` pipeline runs `check:format:repo` on PRs touching any files 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the MAI extension to the codespace image and suggests it for non-codespace users.