test: increase ReconnectFarm timeout from 30s to 60s#26583
test: increase ReconnectFarm timeout from 30s to 60s#26583frankmueller-msft wants to merge 1 commit intomainfrom
Conversation
The ReconnectFarm stress test runs randomized merge-tree operations with reconnection and can intermittently exceed the 30s timeout on CI machines under load. Doubling the timeout reduces flaky failures without changing what the test validates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces CI flakiness in the MergeTree reconnect stress fuzz tests by increasing the Mocha timeout threshold for ReconnectFarm from 30s to 60s, accommodating slower CI machines under load without changing test behavior.
Changes:
- Increase
ReconnectFarmtest timeout from30 * 1000to60 * 1000.
|
what is the impetus for this change? I'm not aware of these tests being flaky in the PR build or CI? is there any associated issue? In general, i don't like just increasing timeouts, as it can lead to performance regression over time. i managed to find 379358, but that is a topic branch run, not a run on main. i think we need more evidence that this is all a net good, before we make changes. I worry that our build machines are under resourced for the parallelism, and we are trading time for stability, which is not a good trade off. |
|
Fair points. To give context: the timeout failure in build 379358 was on the I haven't seen this fail on main, so the evidence for a standalone timeout increase is weak. The right path is probably to close this and monitor after #26586 merges — if Closing this. |
Summary
Increases the timeout for the
ReconnectFarmstress tests from 30s to 60s. These tests run randomized merge-tree operations with reconnection and can intermittently exceed the 30s timeout on CI machines under load, causing flakyTimeout of 30000ms exceededfailures.Observed in build 379358:
MergeTree.Client > ReconnectFarm_2_0timed out with 1554 other tests passing.Coverage audit
No change to what the test validates — same operations, same assertions, same seed-based determinism. Only the timeout threshold changed.
Test plan
30 * 1000→60 * 1000🤖 Generated with Claude Code