Simplify getDeviceSpec and navigator test cleanup

[ChumpChief]

Description

Now that we require Node 22 (#26934), navigator is always available (in both browsers
and Node 22). This simplifies getDeviceSpec() and its tests:

• Remove the typeof navigator === "object" guard and try/catch from getDeviceSpec()
  since navigator is always present in supported environments.
• Replace the as any cast for deviceMemory with a typed intersection cast
  (Navigator & { deviceMemory?: number }), eliminating three eslint disables.
• Remove the null and undefined navigator test cases since no supported environment
  has a missing navigator.
• Add a Node-native navigator test case that verifies hardwareConcurrency is a number
  and deviceMemory is undefined (matching Node 22's built-in navigator behavior).
• Simplify restoreNavigator by removing the delete branch (Node 22 always provides
  a navigator descriptor to restore).

These improvements were identified during review of #26938.

AB#68707

Reviewer Guidance

The review process is outlined on this wiki page.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Simplifies getDeviceSpec() and related tests under the assumption that Node 22+ is the supported runtime and navigator is always present.

Changes:

• Simplifies getDeviceSpec() by removing the runtime guard/try-catch and using a typed cast for deviceMemory.
• Updates hardware stats tests to remove null/undefined navigator scenarios and add a Node-native navigator case.
• Simplifies navigator test restoration logic by always restoring the original property descriptor.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
packages/runtime/container-runtime/src/containerRuntime.ts	Removes guard/try-catch around navigator access and uses typed intersection for deviceMemory.
packages/runtime/container-runtime/src/test/hardwareStats.spec.ts	Updates navigator mocking/restoration and modernizes test cases for Node 22 behavior.

[jason-ha]

Where do we document to customers that Node 22+ is required to use FF client?
Is there any enforcement via package management?

[ChumpChief]

Ah, I forgot to update the readmes 🤦‍♂️ the main one is https://github.com/microsoft/FluidFramework/blob/main/ClientRequirements.md but the template gets pasted in every README. I've opened #27039 to update the readmes.

[jason-ha]

Okay - lets hold this breaking change until at least 2.100.
Please do also add a breaking change changeset. This is one of those rare cases where we can make a breaking change without a major. ... If we want to do yearly majors as recently discussed, then April might be the time to do so each year and include the Node requirement.

[jason-ha]

Good to proceed now that 2.100 is the active window.
Please do add changeset highlighting Node22 requirement - should be a general all packages note.

[ChumpChief]

Opened #27116 for the all-packages breaking change notice and also ensuring the engines field is correct for all workspaces. For this PR, the latest iteration has an additional specific changeset detailing the impact of this navigator dependency.

[github-actions]

🔭 PR Review Fleet Report

Note

This report is generated by an experimental AI review fleet and is provided as a beta feature. Findings are a starting point for discussion, not a gate. Use your own judgement.

Verdict: ❌ Request Changes

0 Exterminate, 1 Squash, 0 Investigate

Findings

Sev	#	Area	File	What	Fix
🦟 Squash	H1	Correctness	packages/runtime/container-runtime/src/containerRuntime.ts:680	The removal of the try/catch and typeof navigator === "object" guard means that in any environment where navigator is not a global (Node.js < 22, server-side JS runtimes, non-browser environments that happen to use this package), accessing navigator directly will throw ReferenceError: navigator is not defined. The old code intentionally caught this case; the new code silently assumes navigator is always present. The package itself declares no engine requirement for Node >=22, so downstream consumers on older Node versions hit this crash path during ContainerRuntime.loadRuntime2 (called at line 2140, which spreads getDeviceSpec() into a telemetry send)	failing container initialization entirely on every connect. — Restore the guard: wrap the body with if (typeof navigator !== "undefined" && navigator !== null), returning {} otherwise; or, if Node

---

View workflow run