Reduce data size in tests with perf issues#27168
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (8 lines, 2 files), I've queued these reviewers:
Toggle the reviewer checkboxes above to adjust, then tick the box below to start:
|
There was a problem hiding this comment.
Pull request overview
Adjusts SharedTree table benchmark/test parameters to reduce runtime in CI by lowering the default (non-performance-mode) table size and operation counts, mitigating intermittent timeouts when running the full test suite.
Changes:
- Reduce non-perf
tableSizesfrom[5]to[3]in table execution-time benchmarks. - Reduce non-perf
operationCountsfrom[5]to[3]in table execution-time benchmarks. - Apply the same non-perf reductions to the corresponding memory-usage benchmarks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/dds/tree/src/test/shared-tree/tableTree.bench.ts | Lowers default (non-perf) table size and operation count to reduce benchmark runtime during regular test runs. |
| packages/dds/tree/src/test/memory/tableTree.spec.ts | Lowers default (non-perf) table size and operation count to reduce memory benchmark runtime during regular test runs. |
| // The test tree's size will be 5*5, 50*50. | ||
| // Table size 1000 benchmarks removed due to high overhead and unreliable results. | ||
| const tableSizes = isInPerformanceTestingMode | ||
| ? [5, 50] | ||
| : // When not measuring perf, use a single smaller data size so the tests run faster. | ||
| [5]; | ||
| [3]; |
There was a problem hiding this comment.
The comment says the test tree size will be 5×5 and 50×50, but in non-performance mode this now runs with a 3×3 table. Please update the comment to reflect the two modes (perf vs non-perf) to avoid confusion when reading results.
| // The test tree's size will be 5*5, 50*50. | ||
| // Tree size 1000 benchmarks removed due to high overhead and unreliable results. | ||
| const tableSizes = isInPerformanceTestingMode | ||
| ? [5, 50] | ||
| : // When not measuring perf, use a single smaller data size so the tests run faster. | ||
| [5]; | ||
| [3]; |
There was a problem hiding this comment.
The comment indicates the test tree sizes will be 5×5 and 50×50, but in non-performance mode this now uses a 3×3 table. Please adjust the comment to describe both perf and non-perf modes so the chosen sizes are clear.
Description
Something is causing these tests, at least the execution time ones, to be much slower when run as part of the full test suite instead of by themselves.
This is causing non-determinstic timouts on CI.
THis change reduces the data size to hopefully mitigate the issue while it is properly investigated and fixed.
Reviewer Guidance
The review process is outlined on this wiki page.