docs(ci-readiness-check): require explicit mode prompt before running#27198
Merged
Conversation
Tightens the <required> block in the ci-readiness-check skill so the agent cannot silently default to a mode (e.g. Build) when the skill fires. The agent must now ask the user the Step 1 mode-choice question unless one of two narrow, explicit exceptions applies, and must report every implicit skip and the reason for it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (11 lines, 1 files), I've queued these reviewers:
Toggle the reviewer checkboxes above to adjust, then tick the box below to start:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ci-readiness-check skill’s <required> preamble to prevent silent “Build mode” runs by requiring an explicit user mode choice up front, even in auto/autonomous operation.
Changes:
- Makes the Step 1 mode-selection prompt an explicit MUST-do-first instruction.
- Defines two narrow exceptions for when the prompt may be skipped and requires explicit reporting when an exception is used.
- Reiterates task/todo creation requirements immediately after the user responds.
… example Address review feedback on PR microsoft#27198 plus a finding from a behavioral probe of the new rule. - Replaces the loose "unrelated markdown" example with a concrete list ("files under .claude/", repo-root README/CHANGELOG, top-level docs not in a docs/* package) and an explicit warning that workspace packages like docs/api/ do NOT qualify just because their content is markdown. The probe agent applied the exception too loosely to a docs/api/README.md edit because of this ambiguity. - Clarifies that "applying an exception" means treating the moment as if the user picked Skip: no mode question, no tasks, no script run, stop the skill. Per Copilot review comment. - Splits the report-the-skip rule into three explicit clauses (skipped asking, skipped the check, which exception) so the obligation is unmissable. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
tylerbutler
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A user reported that the
ci-readiness-checkskill would silently run inBuild mode (the expensive one) every time they pushed, instead of asking
which mode to run. Step 1 of the skill already said to ask the user, but
the directive was buried below the
<required>block, soft-worded("Step 1 asks the user..."), and not enforced against auto/autonomous mode.
This change rewrites the lead of the
<required>block to make the promptunmissable:
asking (no-op since the previous check in this conversation; explicit
standing user instruction), with conservative wording so subjective "I
think nothing important changed" does not qualify.
which exception applied — every time, with no abbreviation across
repeated runs.
Reviewer Guidance
The review process is outlined on this wiki page.