Skip to content

docs(ci-readiness-check): require explicit mode prompt before running#27198

Merged
noencke merged 2 commits into
microsoft:mainfrom
noencke:ci-readiness-require-prompt
May 1, 2026
Merged

docs(ci-readiness-check): require explicit mode prompt before running#27198
noencke merged 2 commits into
microsoft:mainfrom
noencke:ci-readiness-require-prompt

Conversation

@noencke
Copy link
Copy Markdown
Contributor

@noencke noencke commented Apr 29, 2026

Description

A user reported that the ci-readiness-check skill would silently run in
Build mode (the expensive one) every time they pushed, instead of asking
which mode to run. Step 1 of the skill already said to ask the user, but
the directive was buried below the <required> block, soft-worded
("Step 1 asks the user..."), and not enforced against auto/autonomous mode.

This change rewrites the lead of the <required> block to make the prompt
unmissable:

  • States as a MUST that the agent ask the Step 1 mode-choice question first.
  • Explicitly disqualifies "we're in auto mode" as a justification to skip.
  • Defines exactly two narrow exceptions where the agent may proceed without
    asking (no-op since the previous check in this conversation; explicit
    standing user instruction), with conservative wording so subjective "I
    think nothing important changed" does not qualify.
  • Requires that, in both exceptions, the agent still report the skip and
    which exception applied — every time, with no abbreviation across
    repeated runs.

Reviewer Guidance

The review process is outlined on this wiki page.

Tightens the <required> block in the ci-readiness-check skill so the
agent cannot silently default to a mode (e.g. Build) when the skill
fires. The agent must now ask the user the Step 1 mode-choice question
unless one of two narrow, explicit exceptions applies, and must report
every implicit skip and the reason for it.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 29, 2026 00:06
@github-actions
Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (11 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

Toggle the reviewer checkboxes above to adjust, then tick the box below to start:

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ci-readiness-check skill’s <required> preamble to prevent silent “Build mode” runs by requiring an explicit user mode choice up front, even in auto/autonomous operation.

Changes:

  • Makes the Step 1 mode-selection prompt an explicit MUST-do-first instruction.
  • Defines two narrow exceptions for when the prompt may be skipped and requires explicit reporting when an exception is used.
  • Reiterates task/todo creation requirements immediately after the user responds.

Comment thread .claude/skills/ci-readiness-check/SKILL.md Outdated
… example

Address review feedback on PR microsoft#27198 plus a finding from a behavioral
probe of the new rule.

- Replaces the loose "unrelated markdown" example with a concrete list
  ("files under .claude/", repo-root README/CHANGELOG, top-level docs
  not in a docs/* package) and an explicit warning that workspace
  packages like docs/api/ do NOT qualify just because their content
  is markdown. The probe agent applied the exception too loosely to a
  docs/api/README.md edit because of this ambiguity.
- Clarifies that "applying an exception" means treating the moment as
  if the user picked Skip: no mode question, no tasks, no script run,
  stop the skill. Per Copilot review comment.
- Splits the report-the-skip rule into three explicit clauses (skipped
  asking, skipped the check, which exception) so the obligation is
  unmissable.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  288641 links
    1922 destination URLs
    2172 URLs ignored
       0 warnings
       0 errors


@noencke noencke enabled auto-merge (squash) April 30, 2026 21:55
@noencke noencke merged commit 3e6f512 into microsoft:main May 1, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants