Skip to content

Dev Container: Refresh 'docker-from-docker' and Chromium#5851

Merged
DLehenbauer merged 1 commit intomainfrom
dockerfile
Apr 20, 2021
Merged

Dev Container: Refresh 'docker-from-docker' and Chromium#5851
DLehenbauer merged 1 commit intomainfrom
dockerfile

Conversation

@DLehenbauer
Copy link
Copy Markdown
Contributor

@DLehenbauer DLehenbauer commented Apr 19, 2021

Not much "real" change, just a different way of doing the same things:

  • Leverages newer 'docker-from-docker' template to proxy docker socket into dev container.
  • Installs 'Chromium' in order to get Puppeteer dependencies instead of installing them manually.
  • Fixed Tinylicious port to new 7070.

(I was having some trouble debugging Puppeteer tests in a dev container. Turned out to be unrelated, but though I'd keep the changes.)

@DLehenbauer DLehenbauer merged commit af44f79 into main Apr 20, 2021
@DLehenbauer DLehenbauer deleted the dockerfile branch April 20, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants