Adding logo. Different in light and dark mode#293
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds new logo variations for the Foundry Local branding and integrates them across the site. The changes update the visual identity from Azure placeholders to custom Foundry Local logos with support for different theme contexts.
- Adds three new SVG logo variants (color, filled, and stroke)
- Introduces
logoMarkconfiguration option for compact contexts - Updates logo usage in the hero section and sidebar with proper theme support
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| www/static/logos/foundry-local-logo-stroke.svg | New stroke-only logo variant for compact/monochrome contexts |
| www/static/logos/foundry-local-logo-fill.svg | New filled white logo variant for dark theme usage |
| www/static/logos/foundry-local-logo-color.svg | New color gradient logo variant for light theme usage |
| www/src/lib/types/config.ts | Adds logoMark field to SiteConfig interface for compact logo variant |
| www/src/lib/config.ts | Updates logo paths from Azure placeholders to new Foundry Local logos |
| www/src/lib/components/home/hero.svelte | Adds logo display with theme-aware variants and adjusts animation timings |
| www/src/lib/components/app-sidebar.svelte | Replaces icon with compact logo variant in sidebar header |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import * as Sidebar from '$lib/components/ui/sidebar/index.js'; | ||
| import { siteConfig } from '$lib/config'; | ||
| import GalleryVerticalEnd from 'lucide-svelte/icons/gallery-vertical-end'; | ||
| import type { ComponentProps } from 'svelte'; |
There was a problem hiding this comment.
[nitpick] The ComponentProps import should be moved above the component imports to maintain the conventional import ordering: types first, then external libraries, then internal modules, then components.
| <img | ||
| src={compactLogo} | ||
| alt="Foundry Local logo" | ||
| class="h-5 w-5" |
There was a problem hiding this comment.
The fixed dimensions h-5 w-5 may distort the logo if its aspect ratio is not 1:1. The stroke logo appears to have a square viewBox (279x279), but using object-fit or allowing flexible width while constraining only height would be more robust. Consider using class=\"h-5 w-auto\" instead.
| class="h-5 w-5" | |
| class="h-5 w-auto" |
No description provided.