Skip to content

[sdk_v2] implements progress callback for model download in js #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathikr merged 2 commits into from
Feb 18, 2026
Merged

[sdk_v2] implements progress callback for model download in js #441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddcdf77
impl
Feb 17, 2026
df2dcea
Merge remote-tracking branch 'origin' into prathikrao/js-progress-cal…
Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sdk_v2/js/src/modelVariant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,17 @@ export class ModelVariant implements IModel {
* @param progressCallback - Optional callback to report download progress.
* @throws Error - If progress callback is provided (not implemented).
*/
public download(progressCallback?: (progress: number) => void): void {
public async download(progressCallback?: (progress: number) => void): Promise<void> {
const request = { Params: { Model: this._modelInfo.id } };
if (!progressCallback) {
this.coreInterop.executeCommand("download_model", request);
} else {
throw new Error("Download with progress callback is not implemented yet.");
await this.coreInterop.executeCommandStreaming("download_model", request, (chunk: string) => {
const progress = parseFloat(chunk);
if (!isNaN(progress)) {
progressCallback(progress);
}
});
}
}

Expand Down