Skip to content

Use bytes instead of string length #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathikr merged 2 commits into from
Feb 26, 2026
Merged

Use bytes instead of string length #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b5b576
Use bytes instead of str length
baijumeswani Feb 26, 2026
5591159
Use private instead of private static
baijumeswani Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions sdk_v2/js/src/detail/coreInterop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ export class CoreInterop {
return null;
}

private _toBytes(str: string): Uint8Array {
return new TextEncoder().encode(str);
}

constructor(config: Configuration) {
const corePath = config.params['FoundryLocalCorePath'] || CoreInterop._resolveDefaultCorePath(config);

Expand Down Expand Up @@ -96,14 +100,15 @@ export class CoreInterop {
koffi.encode(cmdBuf, 'char', command, command.length + 1);

const dataStr = params ? JSON.stringify(params) : '';
const dataBuf = koffi.alloc('char', dataStr.length + 1);
koffi.encode(dataBuf, 'char', dataStr, dataStr.length + 1);
const dataBytes = this._toBytes(dataStr);
const dataBuf = koffi.alloc('char', dataBytes.length + 1);
koffi.encode(dataBuf, 'char', dataStr, dataBytes.length + 1);

const req = {
Command: koffi.address(cmdBuf),
CommandLength: command.length,
Data: koffi.address(dataBuf),
DataLength: dataStr.length
DataLength: dataBytes.length
};
const res = { Data: 0, DataLength: 0, Error: 0, ErrorLength: 0 };

Expand All @@ -129,8 +134,9 @@ export class CoreInterop {
koffi.encode(cmdBuf, 'char', command, command.length + 1);

const dataStr = params ? JSON.stringify(params) : '';
const dataBuf = koffi.alloc('char', dataStr.length + 1);
koffi.encode(dataBuf, 'char', dataStr, dataStr.length + 1);
const dataBytes = this._toBytes(dataStr);
const dataBuf = koffi.alloc('char', dataBytes.length + 1);
koffi.encode(dataBuf, 'char', dataStr, dataBytes.length + 1);

const cb = koffi.register((data: any, length: number, userData: any) => {
const chunk = koffi.decode(data, 'char', length);
Expand All @@ -142,7 +148,7 @@ export class CoreInterop {
Command: koffi.address(cmdBuf),
CommandLength: command.length,
Data: koffi.address(dataBuf),
DataLength: dataStr.length
DataLength: dataBytes.length
};
const res = { Data: 0, DataLength: 0, Error: 0, ErrorLength: 0 };

Expand Down